Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New user or Admin user should have password collected as SecureString #5

Open
ionTomorrow opened this issue Apr 12, 2021 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request invalid This doesn't seem right

Comments

@ionTomorrow
Copy link
Owner

functions that deal with creating new users or updating their passwords should use convertTo-SecureString and convertFrom-SecureSting to that the password is never available in plaintext

@ionTomorrow ionTomorrow added the enhancement New feature or request label Apr 12, 2021
@bdeyo-vmware bdeyo-vmware added documentation Improvements or additions to documentation invalid This doesn't seem right labels Aug 23, 2021
@bdeyo-vmware
Copy link
Collaborator

The functions themselves should technically have this done now in the next pull request.

However if an admin is still typing the function at the prompt, the -password value would still show as a plainText string. Although a read-host within the function could prompt to type the secureString, that would be extra work.

How to get a user to create their password as a secureString before passing this is important. Perhaps if there is some easy fail option where if it's not a secureString when passed as a parameter the function then prompts for correction?

@ionTomorrow ionTomorrow linked a pull request Aug 30, 2021 that will close this issue
@ionTomorrow ionTomorrow removed a link to a pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants