Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle type Service records / how to handle types that are not supported by the front-end #133

Open
jmckenna opened this issue May 7, 2024 · 2 comments

Comments

@jmckenna
Copy link
Contributor

jmckenna commented May 7, 2024

  • some partners have JSON-LD with type Service
  • however, if those records are loaded into Solr and exposed on the front-end, the entire front-end breaks
    • because none of the 7 types supported by the front-end, are of type Service
    • and because the records contain spatial, when a user clicks on Spatial Search the entire page will break (JS error / blank page) see screen capture below
  • for several years now I 'get around this' by changing the type through the Solr indexer to something that is supported in the front-end (such as changing type SoftwareSourceCode to type CreativeWork ie. issue Handle CreativeWork sub-type "SoftwareSourceCode" #131 )
  • I could temporarily change the type Service records to display as type Dataset, but, that seems incorrect, if partners have records of type Service that have nothing to do with data.

What is the way forward?

Screenshot 2024-05-07 163225

related to: iodepo/odis-arch#322

@jmckenna jmckenna changed the title handle type Service records handle type Service records / how to handle types that are not supported by the front-end May 7, 2024
@pbuttigieg
Copy link
Collaborator

pbuttigieg commented May 7, 2024

No. the TOR of the contracts issued to both the back and front end include terms for adding arbitrary types to the UI .

if we can't add a service facet, these TOR are violated. this is trivial- it's just another type.

there must be no workarounds or tricks. ANY new type MUST be supported.

This has been known for years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants