-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic response for empty URL key #123
Comments
Good morning @pbuttigieg , while I was trying to test the implementation of the functionality you requested, I noticed that the example you sent contains a not empty URL. However, the URL doesn't work, so it's not possible to see the expected behavior with that type of result. If I try to force an empty URL from the code, this is what I get when clicking on it. The JsonLD is also interactive. As you can see: https://oih.trust-it.it/record/id=f5c5469c3dbff9e4b92ecd6f4b869a9d |
The URL property is empty
I'm not sure what you mean. The URL to the record is fine, but the
That looks good. If all records with empty (or - if you can implement easily - that return 404, 503, etc) |
@dev-marcoC thanks for finding the missing link, I didn't realise that SOLR did this. Yes, that code looks right. |
To be clear, this should apply to all types, not only Person or Organization. I know that was only example code, but just in case. Also, the only property that should be triggered when a result title in the UI is clicked, is the top-level |
Some records are "metadata only" and don't have landing pages and thus the top-level url property is empty
This means that clicking on the search result title/link will send users no where
For example :
https://api.search.oceaninfohub.org/source?id=http%3A%2F%2Fportete.invemar.org.co%2Fchm%2Fapi%2Foih%2Ffindid%2Fvessel%2F6b86bafde9894e2bfcd0db5deaeb12a6b57bceaea9bf0835639bc59628c544c9
Could we have a default behaviour for this scenario ?
A page that says - "This is a metadata only record" and then displays the JSON in a pretty-print form ?
The text was updated successfully, but these errors were encountered: