-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left panel #120
Comments
(7) given own issue |
I'm testing on here, so things may have changed: https://mosaic-staging.chpc.utah.edu/sv.iobio/frontend/
|
That's a good point on the star. I also agree on consistency. We have a family of tools in Mosaic and iobio apps and where we can have consistency between them, we should |
Do you want to start a new issue? This issue was just about the left panel. I'm going to add additional issues for the other parts of the app |
@AlistairNWard I'm sorry I'm not sure what you mean here. Is it the lowercase 'k'? It should be capitalized to mirror Mb. But are you not wanting a subscript style on the scaling? |
Sorry - should NOT be a subscript. Lowercase k and upper case M are standard |
@mvelinder Totally right, I just added the summary recently and it does make those other columns redundant in my opinion. I think we can free up that space maybe and add a few of the other more important SV related metrics. Freeing up two columns might allow room for Al's num 9. |
@emersonlebleu this is now #126 |
Update the title row labels to match #120
This will probably need to be broken up into smaller issues. Any suggestions are just suggestions and we should probably have some UI sessions with the iobio team / other users to optimise things.
@mvelinder Any thoughts on the left panel when you try and use the app?
Max Patient Phenotypes probably won't mean much to people. How about Gene:HPO associations?People will most likely not have any genes of interest. Even if they do, they will probably start out without any, so seeing "n/a / 1" is almost a guarantee and I think it's pretty ugly. Why not have the column as Genes (GoI) and use 0 if there are no defined genes of interest. This way, you will see 1 (0) which looks a lot better imo. Or maybe they should be their own columns - GoI only showing if any are selected. This would help with sorting (4 below)You can use HOM instead of HOM ALT for the inheritance column. The title should be Zygosity - this isn't mode of inheritance. This is pretty standard. Also, you could put HOM in red so we can quickly spot HOM genotypes.Can we click on column headers to sort? We have to go to the sort button at the top left to choose between sorting on HPO, overlapped genes, genes of interest. I also want to sort on type or zygosity, so the standard way of doing that would just be to click on the column titlekb should be a subscript in the length, e.g. 1.1Kb or 1.1MbDONE Changed as suggestedIt would probably useful to include the chromosome in the left panelDONE Changed as suggestedFavourite SVs. If a user is stepping through the variants in the left panel, they may find some they find interesting and want to come back to. We could include a favourite mechanism, e.g. a star like in Mosaic. Then you could sort on the star column to bring all favourite SVs to the topIssue MadeI don't think people will know what an UNKNOWN ALT is. A./1
genotype is still a het, so I would recommend leaving this as HET in the zygosity column. If you select the variant, you can then see the actual genotypeand the condensed view:
Maybe we could do something similar? Expanded view could include the coordinate and the condensed view wouldn't. The type and zygosity could be different in the different views. E.g. HET could be and HOM could be , for example. I'm not sure how much space we'd save if the column width is driven by the title, but worth considering
The text was updated successfully, but these errors were encountered: