Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ack handling #58

Open
ltigges opened this issue Nov 18, 2022 · 4 comments
Open

Ack handling #58

ltigges opened this issue Nov 18, 2022 · 4 comments
Labels

Comments

@ltigges
Copy link

ltigges commented Nov 18, 2022

Hi all,
In my opinion, the ack flag is not processed correctly. Currently the messages are sent with ack request and the ack flag is set in the iobroker as soon as the ack confirmation arrives.
However, the IOB ack is normally set as soon as an actuator has performed an action and not as soon as the data transmission was successful. Therefore ideally the Mysensors ack should be used to retrigger the data transfer if it fails but in no way to set the IOB ack flag.

@Apollon77
Copy link
Contributor

This depends on the device. IF there is a reponse of the device about the change nut no new values then a successfull sending is the only way to set the ack flag ...

@ltigges
Copy link
Author

ltigges commented Nov 18, 2022

As I understand it, the IOB ack should only be set when the command has been completed. With a relay the current implementation works but for example with a roller shutter that is controlled by V_PERCENTAGE , the iob ack is already set although the roller shutter is still running.

@Apollon77
Copy link
Contributor

As I understand it, the IOB ack should only be set when the command has been completed.

Yes and no ... formally it is about "the device acknowledged the receiving" - what that in the end means is partly with the device, but when the device has active data reporting no adapter will set "ack=true" itself.

mysensors might be special here because I do not know if the device always report the new value back ... so I can only assume (without looking into it) that the "direct ack" is a workaround in this case ...

@stale
Copy link

stale bot commented May 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions.
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

@stale stale bot added the wontfix label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants