rename and add tests to useDocumentQuery #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: react-query-firebase.invertase.dev/~101 Documentation is deployed and generated using docs.page. |
HassanBahati
force-pushed
the
add-usefirestoredocument-tests
branch
from
7c42b42
to
4f6e660
Compare
Ehesp
requested changes
Sep 18, 2024
| expect(result.current.isError).toBe(true); | ||
| }); | ||
|
|
||
| expect(result.current.error).toBeDefined(); |
There was a problem hiding this comment.
Could we make a test utility here which does something along the lines of expectFirestoreError(result.current.error, 'firebase-code'), and both checks .code is defined and matches what is expected? We could hit a false positive here with it being an error unrelated to the none existent doc.
There was a problem hiding this comment.
sure yes, i do agree. let me setup a utility to run that check
HassanBahati
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests the
useDocumentQueryhook for the following assertions;