fixed bug of pagination disappearing after a custom query state update #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
reviewed
Sep 29, 2021
src/lib/state/actions/query.js
Outdated
| dispatch({ | ||
| type: SET_QUERY_STATE, | ||
| payload: queryState, | ||
| payload: {size, page, ...queryState}, |
There was a problem hiding this comment.
Question: would it be safer or more correct to this the following instead?
Suggested change
| payload: {size, page, ...queryState}, | |
| const { query: currentQueryState } = getState() | |
| payload: {...currentQueryState, ...queryState}, |
There was a problem hiding this comment.
i think it in terms of safeness there is no big difference, because it both cases the new queryState object will override either the whole currentQueryState or just the page and size properties, if it has overlapping properties. At least that is how i interpret safeness 🤔
NRodriguezcuellar
force-pushed
the
master
branch
from
64b203d
to
5353d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pagination menu was disappearing after using the custom query build helper of ILS. After investigation i learned that this was because it defaulted back to the initial state if no page number or size was passed while updating the state. It now takes the current values if those 2 properties are not passed with the payload.
closes inveniosoftware/react-invenio-app-ils#344