Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All vocabularies endpoint and Admin interface #310

Merged
merged 28 commits into from
Jul 10, 2024

Conversation

karkraeg
Copy link
Member

❤️ Thank you for your contribution!

Description

Adresses #307

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@karkraeg karkraeg linked an issue May 14, 2024 that may be closed by this pull request
@karkraeg karkraeg marked this pull request as draft May 14, 2024 11:03
@karkraeg karkraeg linked an issue May 17, 2024 that may be closed by this pull request
@karkraeg karkraeg marked this pull request as ready for review May 17, 2024 09:21
@karkraeg karkraeg requested a review from slint May 17, 2024 09:22
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some nits and minor comments (and possibly non-important things we shelve in issues).

invenio_vocabularies/administration/__init__.py Outdated Show resolved Hide resolved
invenio_vocabularies/administration/views/vocabularies.py Outdated Show resolved Hide resolved
invenio_vocabularies/administration/views/vocabularies.py Outdated Show resolved Hide resolved
invenio_vocabularies/config.py Show resolved Hide resolved
invenio_vocabularies/config.py Outdated Show resolved Hide resolved
invenio_vocabularies/resources/config.py Show resolved Hide resolved
invenio_vocabularies/resources/config.py Outdated Show resolved Hide resolved
invenio_vocabularies/services/service.py Outdated Show resolved Hide resolved
@karkraeg
Copy link
Member Author

@SarahW91
Copy link
Contributor

I added Uni Münster in the copyright header in the files where we added larger changes. Hope that's okay, otherwise I can remove it again.

@SarahW91 SarahW91 linked an issue Jun 17, 2024 that may be closed by this pull request
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the clean-up and splitting up the resource and service configs. I think this is looking good and most of my comments are about naming or removing duplicated or redundant config vars and attributes.

I know it's a lot of comments, so if you prefer we could also organize a quick call and go through some of the heavier ones together.

invenio_vocabularies/ext.py Outdated Show resolved Hide resolved
invenio_vocabularies/resources/__init__.py Show resolved Hide resolved
invenio_vocabularies/resources/resource.py Outdated Show resolved Hide resolved
invenio_vocabularies/services/config.py Outdated Show resolved Hide resolved
invenio_vocabularies/services/config.py Outdated Show resolved Hide resolved
invenio_vocabularies/services/config.py Outdated Show resolved Hide resolved
invenio_vocabularies/services/config.py Outdated Show resolved Hide resolved
invenio_vocabularies/services/config.py Outdated Show resolved Hide resolved
invenio_vocabularies/services/config.py Outdated Show resolved Hide resolved
invenio_vocabularies/services/service.py Outdated Show resolved Hide resolved
@SarahW91 SarahW91 mentioned this pull request Jun 26, 2024
6 tasks
@slint slint merged commit 810583f into inveniosoftware:master Jul 10, 2024
16 checks passed
carlinmack added a commit to carlinmack/zenodo-rdm that referenced this pull request Jul 17, 2024
📁 invenio-administration (2.4.0 -> 2.4.1 ��)

    📦 release: v2.4.1
    global: remove dependency on invenio-vocabularies

    * Removes the dependency from invenio-vocabularies.
    * Delegates administration UI schema type definition to the mashmallow
      class.

📁 invenio-app-rdm (13.0.0b0.dev6 -> 13.0.0b0.dev8 )

    📦 release: v13.0.0b0.dev8
    previewer: gracefuly handle default preference
    📦 release: v13.0.0b0.dev7
    datastreams: add affiliations and update funders

📁 invenio-banners (3.0.1 -> 3.0.2 🐛)

    release: v3.0.2
    errors: fix validation errors not propagated to resource
    administration: set default category to info

    * Fixes inveniosoftware/invenio-banners#26 by setting default category value,
      which is a required field.

📁 invenio-rdm-records (11.3.1 -> 11.4.0 🌈)

    📦 release: v11.4.0
    affiliations: update defaults to ror v2

📁 invenio-rest (1.3.0 -> 1.3.1 🐛)

    release: v1.3.1
    tests; fix csrf tests
    csrf: improve validation

    * inveniosoftware/invenio-rest#132

📁 invenio-vocabularies (4.0.0 -> 4.1.1 🌈)

    📦 release: v4.1.1
    installation: use invenio-oaipmh-scythe from PyPI
    📦 release: v4.1.0
    readers: make OAI-PMH an optional extra
    schema: add administration UI attributes
    ror: fix duplicate acronymns and aliases
    affiliations: fix title search
    datastreams: have yaml writer output utf8
    datastreams: add configs for funders and affiliations
    affiliations: add datastreams
    datastreams: move ror transformer to common
    affiliations: add new fields
    vocabulary-types: services, resources, and administration UI (inveniosoftware/invenio-vocabularies#310)

    config: add OpenAIRE mapping for "Latvian Council of Science"
    tasks: fixed exception logging
    funding: update award label
    funders: fix country name display (inveniosoftware/invenio-vocabularies#343)
    first implementation of OAIPMHReader (inveniosoftware/invenio-vocabularies#329)

    * first implementation of OAIPMHReader

    * introduce a simple way to map OAI records to a dict without expecting a special metadata format.

    * fix installation requirements

    * fix tests

    * small fixes to make the tests run

    * add error handling

    * renamed oaipmh_scythe package

    * handle remarks/questions from review.

    * replaced access to a real OAI server with a mocking implementation.

    * Update invenio_vocabularies/datastreams/readers.py

    * Update tests/datastreams/test_datastreams.py

    * Moved reader tests to testreaders.py

    * add missing copyright in header

    ---------

    global: add "tags" field to all vocabularies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants