Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links: rework links context generation #332

Open
1 task
zzacharo opened this issue Jul 17, 2023 · 0 comments
Open
1 task

links: rework links context generation #332

zzacharo opened this issue Jul 17, 2023 · 0 comments

Comments

@zzacharo
Copy link
Member

zzacharo commented Jul 17, 2023

Comment from @max-moser

See comment

TLDR

  • Improve link generation on service level to be able to override vars. Current solution indicated in the link above is somewhat mixing layers and adds yet another way to update link context. The problem arises from the fact that links need to be customized based on where they are used so you can e.g redirect a user to their dashboard i.e /me/... or general requests detail page...

IMPORTANT

When this issue is addressed and self_html link is modified for the communities-inclusion requests we need to update the following code: https://github.com/inveniosoftware/invenio-app-rdm/pull/2439/files#diff-9de84a5fdfa6ba53af89750b85cc64159fed6dbbdaa806684059a1b512326216R13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant