[SHELVED] generator: allow explicit additional permissions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppanero
reviewed
Oct 29, 2019
| @@ -103,26 +103,54 @@ def query_filter(self, record=None, **kwargs): | |||
|
|
|||
|
|
|||
| class AnyUserIfPublic(Generator): | |||
| """Allows any user if record is public. | |||
| """Allows any user if record is open access. | |||
There was a problem hiding this comment.
Mayor: TBD, But I would prefer not changing the existing generators until the exact issues have been clarified. I would create a different one, namely AnyUserIfOpen.
There was a problem hiding this comment.
Yes, let's wait to see what's the verdict on inveniosoftware/rfcs/pull/12 . I will wait until this is resolved to address this.
|
Blocked until |
fenekku
changed the title
fenekku
force-pushed
the
16_explicit_permissions
branch
from
fecda98
to
3b7b5b3
Compare
fenekku
force-pushed
the
16_explicit_permissions
branch
from
3b7b5b3
to
b86b46c
Compare
fenekku
changed the title
fenekku
changed the title
|
Shelved in favour of access levels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not taking "access_right" into account in the end since it seemed
too purist (but open to adding it back).