Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatible JS major versions #2599

Closed
5 tasks done
ntarocco opened this issue Mar 1, 2024 · 0 comments
Closed
5 tasks done

Fix incompatible JS major versions #2599

ntarocco opened this issue Mar 1, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ntarocco
Copy link
Contributor

ntarocco commented Mar 1, 2024

pywebpack v2.0.0 enforces to have the same major versions when installing the same JS package from different modules.
Looking at the code, the only one that require fixes is react-invenio-forms:

  • invenio_app_rdm/theme/webpack.py: "react-invenio-forms": "^3.0.0
  • invenio_communities/webpack.py: "react-invenio-forms": "^2.0.0" - PR
  • invenio_search_ui/webpack.py: "react-invenio-forms": "^1.0.0" - PR
  • invenio_vocabularies/webpack.py: "react-invenio-forms": "^2.0.0" - PR
  • invenio_rdm_records/webpack.py"react-invenio-forms": "^2.0.0" - PR
  • invenio_administration/webpack.py: "react-invenio-forms": "^1.0.0" - PR

It is a good opportunity to also fix the same in the various package.json.

@ntarocco ntarocco added the bug Something isn't working label Mar 1, 2024
@ntarocco ntarocco self-assigned this Mar 1, 2024
@ntarocco ntarocco closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant