Delete some dead code in readlinks.py #11500
Open
+0
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes dead code from readlinks.py by deleting unused imports and functions. The removed code includes three imports (requests, config, and OpenLibrary) and five functions that were never referenced elsewhere in the codebase. This cleanup improves code maintainability by removing approximately 60 lines of unused code.
Key changes:
- Removed unused imports:
requests,infogami.config, andopenlibrary.api.OpenLibrary - Removed five unused helper functions related to Solr queries and edition lookups
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these are referenced elsewhere.
Technical
Testing
On testing, this seems to load: https://testing.openlibrary.org/api/volumes/brief/isbn/0451526538.json
Screenshot
Stakeholders