#703 silenced two loggings which were output for decryption failures and for any parsing failure (including decryption failure). As before #703, the behaviour on invalid but successfully decrypted prepares was not changed, so they are still forwarded to next handlers.
Succeeding in decrypting the packet but failing to parse it should most lead to an immediate rejection. This should be confirmed from the stream RFC and fixed.
Marking this as good-first-issue as this code isn't too involved, and there are examples of rejection in the interledger-stream already. Also mentoring is available by pinging me or someone else who has been recently active.
#703 silenced two loggings which were output for decryption failures and for any parsing failure (including decryption failure). As before #703, the behaviour on invalid but successfully decrypted prepares was not changed, so they are still forwarded to next handlers.
Succeeding in decrypting the packet but failing to parse it should most lead to an immediate rejection. This should be confirmed from the stream RFC and fixed.
Marking this as
good-first-issueas this code isn't too involved, and there are examples of rejection in theinterledger-streamalready. Also mentoring is available by pinging me or someone else who has been recently active.