Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault Banning #8

Open
gregdhill opened this issue Jul 12, 2021 · 4 comments
Open

Vault Banning #8

gregdhill opened this issue Jul 12, 2021 · 4 comments
Labels
question Further information is requested

Comments

@gregdhill
Copy link
Member

Vaults are slashed on redeem failure, do we also need to ban them for 24h?

@gregdhill gregdhill added the question Further information is requested label Jul 12, 2021
@josef-widder
Copy link

The question was, what is the reason for the punishment delay? The delay stopped them to perform redeems for 24 hours.

As the fees are spread over all participants, the consequence of not being able to act seem unclear.

Perhaps not paying out fees (or reducing their SLA) for 24 hours would make more sense? But I haven't studied the new fee / sla specs and code in detail yet.

@gregdhill
Copy link
Member Author

gregdhill commented Aug 16, 2021

For reference, the following actions are currently prohibited when a Vault is banned:

  • request_issue
  • request_redeem
  • request_replace
  • accept_replace

We have recently removed the SLA module, but the Vault may still earn rewards on locked interBTC unless reimburse == true.

@sander2
Copy link
Member

sander2 commented Aug 16, 2021

I agree that disallowing redeem does not really punish vaults - rather the opposite, since it's in the vault's interest to have as many issued tokens as possible for maximum reward generation.

Perhaps not paying out fees (or reducing their SLA) for 24 hours would make more sense

I like this idea, we could certainly temporarily reduce the vault's stake for the rewards. Although implementing it requires a bit of a change since stake will no longer be equal to the collateral - we would need to separate the accounting for both of these.

@nud3l
Copy link
Member

nud3l commented Aug 16, 2021

Good points. Agree that banning the vaults for 24 hours is not a punishment per se.

Punishment aspect Banning vaults only prevents them from not being able to accept additional issue requests and thus not being able to increase their reward stake in the system. For that reason alone, we might not want to include it.

Vault protection aspect A vault client might experience a temporary outage (e.g., servers are down). In that case, the 24 hour delay might help vault operators that their system is not drained of collateral if they go offline for 24 hours. The punishment delay might actually help them to recover their services. This might be a good enough reason to keep this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants