Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari Issues #158

Open
thehenrymcintosh opened this issue Aug 22, 2017 · 2 comments
Open

Safari Issues #158

thehenrymcintosh opened this issue Aug 22, 2017 · 2 comments

Comments

@thehenrymcintosh
Copy link

Regarding compatibility, I've been having issues running celljs scripts in Safari (9.1.1) while they execute perfectly in Chrome and Firefox.

These are the most common errors I'm getting:

set — cell.js:237 TypeError: undefined is not an object (evaluating 'prop.set.call')
and
set — cell.js:282:93 TypeError: undefined is not an object (evaluating 'Object.getOwnPropertyDescriptor(Object.getPrototypeOf($node), key).set.call')

It seems to be occurring when some event-driven functions are added, such as onkeyup or onclick, while others ($init, $update) do not result in the error. The error completely prevents any of the script from running, and makes the entire app non-functional.

This problem seems fairly universal as it prevents all the celljs demos from running on my version of safari, leaving a blank screen. Is there any way of making this more backwards compatible? I'm a huge fan of celljs and it would be great if someone could find a solution and make this more accessible.

Thanks!

@gliechtenstein
Copy link
Contributor

Could you write up a quick jsfiddle and share the link here? I recently fixed a similar problem for safari so this shouldn't happen. Also would help to know the browser version

@thehenrymcintosh
Copy link
Author

Hi, I'm running safari 9.1.1. I can set up a jsfiddle if you want, but i'm not sure if it's necessary. If you want an example of the error, all of the demos on https://play.celljs.org/ result in one of the two errors I've already listed. What specifically do you need me to do on jsfiddle to help resolve the bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants