Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interagent schema not valid #343

Open
FreekingDean opened this issue Nov 26, 2019 · 3 comments
Open

Interagent schema not valid #343

FreekingDean opened this issue Nov 26, 2019 · 3 comments

Comments

@FreekingDean
Copy link

Not sure if this is the best place to put this, but I believe the schema should be valid, however when running the tools supplied I see that it is not.

schemas/interagent-hyper-schema.json: #/definitions/identity: failed schema #/properties/definitions/additionalProperties: "definitions", "description", "links", "title", "type" weren't supplied.
schemas/interagent-hyper-schema.json: #/definitions/link/properties/href: failed schema #/definitions/resource/properties/properties/patternProperties/^[a-z0-9][a-zA-Z0-9_]*[a-zA-Z0-9]$: No subschema in "anyOf" matched.
schemas/interagent-hyper-schema.json: #/definitions/link/properties/schema: failed schema #/definitions/resource/properties/properties/patternProperties/^[a-z0-9][a-zA-Z0-9_]*[a-zA-Z0-9]$: No subschema in "anyOf" matched.
schemas/interagent-hyper-schema.json: #/definitions/link: failed schema #/properties/definitions/additionalProperties: "definitions", "description", "links", "title", "type" weren't supplied.
schemas/interagent-hyper-schema.json: #/definitions/ref: failed schema #/properties/definitions/additionalProperties: "definitions", "description", "links", "title", "type" weren't supplied.
schemas/interagent-hyper-schema.json: #/definitions/resource/properties/links: failed schema #/definitions/resource/properties/properties/patternProperties/^[a-z0-9][a-zA-Z0-9_]*[a-zA-Z0-9]$: No subschema in "anyOf" matched.
schemas/interagent-hyper-schema.json: #/definitions/resource/properties/properties: failed schema #/definitions/resource/properties/properties/patternProperties/^[a-z0-9][a-zA-Z0-9_]*[a-zA-Z0-9]$: No subschema in "anyOf" matched.
schemas/interagent-hyper-schema.json: #/definitions/resource/properties/strictProperties: failed schema #/definitions/resource/properties/properties/patternProperties/^[a-z0-9][a-zA-Z0-9_]*[a-zA-Z0-9]$: No subschema in "anyOf" matched.
schemas/interagent-hyper-schema.json: #/definitions/resource: failed schema #/properties/definitions/additionalProperties: "definitions", "description", "links", "title", "type" weren't supplied.
schemas/interagent-hyper-schema.json: #/definitions/resourceDefinition: failed schema #/properties/definitions/additionalProperties: "definitions", "description", "links", "title", "type" weren't supplied.
schemas/interagent-hyper-schema.json: #/definitions/resourceProperty: failed schema #/properties/definitions/additionalProperties: "definitions", "description", "links", "title", "type" weren't supplied.
schemas/interagent-hyper-schema.json: #/properties/definitions: failed schema #/properties/properties/additionalProperties: "additionalProperties" is not a permitted key.
schemas/interagent-hyper-schema.json: #/properties/definitions: failed schema #/properties/properties/additionalProperties: "$ref" wasn't supplied.
schemas/interagent-hyper-schema.json: #/properties/links: failed schema #/properties/properties/additionalProperties: "additionalProperties" is not a permitted key.
schemas/interagent-hyper-schema.json: #/properties/links: failed schema #/properties/properties/additionalProperties: "$ref" wasn't supplied.
schemas/interagent-hyper-schema.json: #/properties/properties: failed schema #/properties/properties/additionalProperties: "additionalProperties" is not a permitted key.
schemas/interagent-hyper-schema.json: #/properties/properties: failed schema #/properties/properties/additionalProperties: "$ref" wasn't supplied.
schemas/interagent-hyper-schema.json: #: failed schema #: "description", "links", "type" weren't supplied.
@geemus geemus transferred this issue from interagent/http-api-design Dec 4, 2019
@geemus
Copy link
Member

geemus commented Dec 10, 2019

It's been quite some time since I worked on/around this stuff, but I think it might be expected that this particular schema is not valid on it's own. I think instead it is expected to be a base schema/starting point that you would join other things on top of (or add to) in order to get a full valid schema. (some of the tests seem like they may confirm this, but again I feel really fuzzy on details). Is there a particular reason you would need or want this to be valid, or you just checked and were surprised that it was not?

@FreekingDean
Copy link
Author

I was looking to use the tooling to generate docs on this schema. I believe the other base json-schema meta schemas are valid, I may be alone in wanting this though! :D

@geemus
Copy link
Member

geemus commented Dec 16, 2019

I'm open to supporting a fix if we can figure it out, but am afraid I probably don't have much bandwidth to work on such a fix myself. If you'd like to work on it, I'd certainly be happy to have it and/or to answer questions if you have them. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants