From 276ffc8dd2b7b5e665baf121a0b253df288dafd0 Mon Sep 17 00:00:00 2001 From: Matteo Lodi <30625432+mlodic@users.noreply.github.com> Date: Wed, 25 Oct 2023 17:53:20 +0200 Subject: [PATCH 1/2] removed default TLP as WHITE to avoid unwanted overwrites of playbooks TLP configurations --- pyintelowl/pyintelowl.py | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/pyintelowl/pyintelowl.py b/pyintelowl/pyintelowl.py index 6abeb7b..948960e 100644 --- a/pyintelowl/pyintelowl.py +++ b/pyintelowl/pyintelowl.py @@ -171,7 +171,7 @@ def send_file_analysis_request( Defaults to ``[]`` i.e. all connectors. tlp (str, optional): TLP for the analysis. - (options: ``WHITE, GREEN, AMBER, RED``). Defaults to ``WHITE``. + (options: ``WHITE, GREEN, AMBER, RED``). runtime_configuration (Dict, optional): Overwrite configuration for analyzers. Defaults to ``{}``. tags_labels (List[str], optional): @@ -184,8 +184,6 @@ def send_file_analysis_request( Dict: JSON body """ try: - if not tlp: - tlp = "WHITE" if not analyzers_requested: analyzers_requested = [] if not connectors_requested: @@ -232,7 +230,7 @@ def send_file_analysis_playbook_request( Defaults to ``[]`` i.e. all playbooks. tlp (str, optional): TLP for the analysis. - (options: ``WHITE, GREEN, AMBER, RED``). Defaults to ``WHITE``. + (options: ``WHITE, GREEN, AMBER, RED``). runtime_configuration (Dict, optional): Overwrite configuration for analyzers. Defaults to ``{}``. tags_labels (List[str], optional): @@ -245,8 +243,6 @@ def send_file_analysis_playbook_request( Dict: JSON body """ try: - if not tlp: - tlp = "WHITE" if not playbooks_requested: playbooks_requested = [] if not tags_labels: @@ -296,7 +292,7 @@ def send_observable_analysis_request( Defaults to ``[]`` i.e. all connectors. tlp (str, optional): TLP for the analysis. - (options: ``WHITE, GREEN, AMBER, RED``). Defaults to ``WHITE``. + (options: ``WHITE, GREEN, AMBER, RED``). runtime_configuration (Dict, optional): Overwrite configuration for analyzers. Defaults to ``{}``. tags_labels (List[str], optional): @@ -314,8 +310,6 @@ def send_observable_analysis_request( Dict: JSON body """ try: - if not tlp: - tlp = "WHITE" if not analyzers_requested: analyzers_requested = [] if not connectors_requested: @@ -373,7 +367,7 @@ def send_observable_analysis_playbook_request( Defaults to ``[]`` i.e. all playbooks. tlp (str, optional): TLP for the analysis. - (options: ``WHITE, GREEN, AMBER, RED``). Defaults to ``WHITE``. + (options: ``WHITE, GREEN, AMBER, RED``). runtime_configuration (Dict, optional): Overwrite configuration for analyzers. Defaults to ``{}``. tags_labels (List[str], optional): @@ -391,8 +385,6 @@ def send_observable_analysis_playbook_request( Dict: JSON body """ try: - if not tlp: - tlp = "WHITE" if not playbooks_requested: playbooks_requested = [] if not tags_labels: @@ -685,7 +677,7 @@ def _new_analysis_cli( obj: str, type_: str, check, - tlp: TLPType = "CLEAR", + tlp: TLPType = None, analyzers_list: List[str] = None, connectors_list: List[str] = None, runtime_configuration: Dict = None, @@ -775,7 +767,7 @@ def _new_analysis_playbook_cli( obj: str, type_: str, check, - tlp: TLPType = "CLEAR", + tlp: TLPType = None, playbooks_list: List[str] = None, runtime_configuration: Dict = None, tags_labels: List[str] = None, From f7082c44af1ac7f9e26c39882877eac5913d75b3 Mon Sep 17 00:00:00 2001 From: Matteo Lodi <30625432+mlodic@users.noreply.github.com> Date: Fri, 3 Nov 2023 16:53:11 +0100 Subject: [PATCH 2/2] bump --- .github/CHANGELOG.md | 3 +++ docs/conf.py | 2 +- pyintelowl/version.py | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/CHANGELOG.md b/.github/CHANGELOG.md index 4c7a4e5..11468a8 100644 --- a/.github/CHANGELOG.md +++ b/.github/CHANGELOG.md @@ -1,5 +1,8 @@ # Changelog +## [4.4.5](https://github.com/intelowlproject/pyintelowl/releases/tag/4.4.5) +- Default TLP for analysis is not TLP:CLEAR anymore. For instance, this prevents the client to overwrite the TLP configuration of a Playbook. + ## [4.4.4](https://github.com/intelowlproject/pyintelowl/releases/tag/4.4.4) - Little fixes diff --git a/docs/conf.py b/docs/conf.py index b12a34c..85d338f 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -13,7 +13,7 @@ import os import sys -VERSION = "4.4.4" +VERSION = "4.4.5" GITHUB_URL = "https://github.com/intelowlproject/pyintelowl" sys.path.append(os.path.abspath("../")) diff --git a/pyintelowl/version.py b/pyintelowl/version.py index d39dca2..1962e05 100644 --- a/pyintelowl/version.py +++ b/pyintelowl/version.py @@ -1 +1 @@ -__version__ = "4.4.4" +__version__ = "4.4.5"