Refactor backup logic to simplify backupFile function and streamline agent implementations

Author: fraserk-xero

src/agents/AiderAgent.ts

@@ -25,9 +25,7 @@ export class AiderAgent implements IAgent {
     const mdPath =
       agentConfig?.outputPathInstructions ??
       this.getDefaultOutputPath(projectRoot).instructions;
-    if (!agentConfig?.disableBackup) {
-      await backupFile(mdPath);
-    }
+    await backupFile(mdPath, agentConfig?.disableBackup);
     await writeGeneratedFile(mdPath, concatenatedRules);
 
     const cfgPath =
@@ -40,9 +38,7 @@ export class AiderAgent implements IAgent {
     let doc: AiderConfig = {} as AiderConfig;
     try {
       await fs.access(cfgPath);
-      if (!agentConfig?.disableBackup) {
-        await backupFile(cfgPath);
-      }
+      await backupFile(cfgPath, agentConfig?.disableBackup);
       const raw = await fs.readFile(cfgPath, 'utf8');
       doc = (yaml.load(raw) || {}) as AiderConfig;
     } catch {

src/agents/AugmentCodeAgent.ts

@@ -30,16 +30,12 @@ export class AugmentCodeAgent implements IAgent {
   ): Promise<void> {
     const output =
       agentConfig?.outputPath ?? this.getDefaultOutputPath(projectRoot);
-    if (!agentConfig?.disableBackup) {
-      await backupFile(output);
-    }
+    await backupFile(output, agentConfig?.disableBackup);
     await writeGeneratedFile(output, concatenatedRules);
 
     if (rulerMcpJson) {
       const settingsPath = getVSCodeSettingsPath(projectRoot);
-      if (!agentConfig?.disableBackup) {
-        await backupFile(settingsPath);
-      }
+      await backupFile(settingsPath, agentConfig?.disableBackup);
 
       const existingSettings = await readVSCodeSettings(settingsPath);
       const augmentServers = transformRulerToAugmentMcp(rulerMcpJson);

src/agents/ClaudeAgent.ts

@@ -22,9 +22,7 @@ export class ClaudeAgent implements IAgent {
   ): Promise<void> {
     const output =
       agentConfig?.outputPath ?? this.getDefaultOutputPath(projectRoot);
-    if (!agentConfig?.disableBackup) {
-      await backupFile(output);
-    }
+    await backupFile(output, agentConfig?.disableBackup);
     await writeGeneratedFile(output, concatenatedRules);
   }
   getDefaultOutputPath(projectRoot: string): string {

src/agents/ClineAgent.ts

@@ -22,9 +22,7 @@ export class ClineAgent implements IAgent {
   ): Promise<void> {
     const output =
       agentConfig?.outputPath ?? this.getDefaultOutputPath(projectRoot);
-    if (!agentConfig?.disableBackup) {
-      await backupFile(output);
-    }
+    await backupFile(output, agentConfig?.disableBackup);
     await writeGeneratedFile(output, concatenatedRules);
   }
   getDefaultOutputPath(projectRoot: string): string {

src/agents/CodexCliAgent.ts

@@ -34,9 +34,7 @@ export class CodexCliAgent implements IAgent {
       defaults.instructions;
 
     // Write the instructions file
-    if (!agentConfig?.disableBackup) {
-      await backupFile(instructionsPath);
-    }
+    await backupFile(instructionsPath, agentConfig?.disableBackup);
     await writeGeneratedFile(instructionsPath, concatenatedRules);
 
     // Handle MCP configuration if enabled

src/agents/CopilotAgent.ts

@@ -27,9 +27,7 @@ export class CopilotAgent implements IAgent {
     const output =
       agentConfig?.outputPath ?? this.getDefaultOutputPath(projectRoot);
     await ensureDirExists(path.dirname(output));
-    if (!agentConfig?.disableBackup) {
-      await backupFile(output);
-    }
+    await backupFile(output, agentConfig?.disableBackup);
     await writeGeneratedFile(output, concatenatedRules);
   }
   getDefaultOutputPath(projectRoot: string): string {

src/agents/CursorAgent.ts

@@ -33,9 +33,7 @@ export class CursorAgent implements IAgent {
     const content = `${frontMatter}${concatenatedRules.trimStart()}`;
 
     await ensureDirExists(path.dirname(output));
-    if (!agentConfig?.disableBackup) {
-      await backupFile(output);
-    }
+    await backupFile(output, agentConfig?.disableBackup);
     await writeGeneratedFile(output, content);
   }
   getDefaultOutputPath(projectRoot: string): string {

src/agents/FirebaseAgent.ts

@@ -22,9 +22,7 @@ export class FirebaseAgent implements IAgent {
   ): Promise<void> {
     const output =
       agentConfig?.outputPath ?? this.getDefaultOutputPath(projectRoot);
-    if (!agentConfig?.disableBackup) {
-      await backupFile(output);
-    }
+    await backupFile(output, agentConfig?.disableBackup);
     await writeGeneratedFile(output, concatenatedRules);
   }
 

src/agents/JunieAgent.ts

@@ -27,9 +27,7 @@ export class JunieAgent implements IAgent {
     const output =
       agentConfig?.outputPath ?? this.getDefaultOutputPath(projectRoot);
     await ensureDirExists(path.dirname(output));
-    if (!agentConfig?.disableBackup) {
-      await backupFile(output);
-    }
+    await backupFile(output, agentConfig?.disableBackup);
     await writeGeneratedFile(output, concatenatedRules);
   }
   getDefaultOutputPath(projectRoot: string): string {

src/agents/KiloCodeAgent.ts

@@ -28,9 +28,7 @@ export class KiloCodeAgent implements IAgent {
     const output =
       agentConfig?.outputPath ?? this.getDefaultOutputPath(projectRoot);
     await ensureDirExists(path.dirname(output));
-    if (!agentConfig?.disableBackup) {
-      await backupFile(output);
-    }
+    await backupFile(output, agentConfig?.disableBackup);
     await writeGeneratedFile(output, concatenatedRules);
   }