Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution deduplication #60

Open
novafacing opened this issue Jan 18, 2024 · 2 comments
Open

Solution deduplication #60

novafacing opened this issue Jan 18, 2024 · 2 comments
Assignees
Labels
enhancement A new feature or enhancement to an existing feature. low-priority Low priority tasks that still need to be completed for an upcoming release. minor A minor change, bug, or feature requiring low effort.

Comments

@novafacing
Copy link
Contributor

Provide options to enable deduplication of solutions:

  • Via stack hash
  • Via IP hash
@novafacing novafacing added minor A minor change, bug, or feature requiring low effort. low-priority Low priority tasks that still need to be completed for an upcoming release. enhancement A new feature or enhancement to an existing feature. labels Jan 18, 2024
@novafacing novafacing self-assigned this Jan 18, 2024
@cglosner
Copy link

cglosner commented Apr 2, 2024

While your adding the deduplication, could you possible add support for printing the stack trace when a solution is found. It shouldn't too difficult because it can be done manually by adding a debug context to the config file:

debug-context object = "qsp.mb.cpu0.core[0][0]"

and then if you run a repro you just need to type in stack-trace to get the file and line information of the stack at crash (as long as its a debug build).

@novafacing
Copy link
Contributor Author

Definitely, this is my plan -- Simics was recently updated to allow stack walking without a debug context, so it is actually even easier than this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or enhancement to an existing feature. low-priority Low priority tasks that still need to be completed for an upcoming release. minor A minor change, bug, or feature requiring low effort.
Projects
None yet
Development

No branches or pull requests

2 participants