Merge pull request #1053 from intel/reschedule-delete

avoid Delete call in controller

Author: pohly

docs/DEVELOPMENT.md

@@ -142,7 +142,7 @@ $ make operator-generate-bundle VERSION=<X.Y.Z> REPLACES=<X.Y.Z> # semantic vers
 ```
 Running the above command generates the OLM package bundle files under `deploy/olm-bundle/<X.Y.Z>`
 
-* Clone `operator-framework/community-operators` repository
+* Clone `k8s-operatorhub/community-operators` repository
 ``` console
 $ git clone https://github.com/k8s-operatorhub/community-operators.git
 ```

pkg/pmem-csi-driver/rescheduler.go

@@ -8,7 +8,6 @@ package pmemcsidriver
 
 import (
 	"context"
-	"errors"
 	"fmt"
 
 	pmemlog "github.com/intel/pmem-csi/pkg/logger"
@@ -74,6 +73,10 @@ type pmemCSIProvisioner struct {
 	provisionController *controller.ProvisionController
 }
 
+var _ controller.Qualifier = &pmemCSIProvisioner{}
+var _ controller.DeletionGuard = &pmemCSIProvisioner{}
+var _ controller.BlockProvisioner = &pmemCSIProvisioner{}
+
 // startRescheduler logs errors and cancels the context when it runs
 // into a problem, either during the startup phase (blocking) or later
 // at runtime (in a go routine).
@@ -131,8 +134,18 @@ func (pcp *pmemCSIProvisioner) Provision(ctx context.Context, opts controller.Pr
 	return nil, controller.ProvisioningNoChange, err
 }
 
+func (pcp *pmemCSIProvisioner) ShouldDelete(context.Context, *v1.PersistentVolume) bool {
+	return false
+}
+
 func (pcp *pmemCSIProvisioner) Delete(context.Context, *v1.PersistentVolume) error {
-	return errors.New("not implemented")
+	return &controller.IgnoredError{
+		Reason: "deletion must be done on the node",
+	}
+}
+
+func (pcp *pmemCSIProvisioner) SupportsBlock(context.Context) bool {
+	return true
 }
 
 func (pcp *pmemCSIProvisioner) shouldReschedule(ctx context.Context, pvc *v1.PersistentVolumeClaim, node *v1.Node) (bool, error) {