Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gen10 support code #1689

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

mattst88
Copy link
Contributor

Gen10 graphics never shipped, and the support code was disabled by default in commit 99adba9 ("Disable Gen10 driver code when -DGEN10=OFF") a few months ago.

 572 files changed, 2 insertions(+), 340589 deletions(-)

@mattst88 mattst88 requested a review from XinfengZhang as a code owner June 29, 2023 21:12
@mattst88
Copy link
Contributor Author

Cc: @XinfengZhang

@mattst88
Copy link
Contributor Author

Anything happening here?

@XinfengZhang
Copy link
Contributor

@mattst88 what's the motivation about the change, it will not impact binary size, only impact the code base size.

@mattst88
Copy link
Contributor Author

Right.

It seems like an obviously good thing for the codebase to remove 340 thousand lines of code that will never be used.

@linyaa-kiwi
Copy link

I love drivers for gen10 gpus. The driver performance and quality is so unbelievable that it can't even be measured.

Despite my passion for git repos with a fat line count, though, this MR is obviously the right thing to do.

@XinfengZhang
Copy link
Contributor

XinfengZhang commented Aug 31, 2023

@mattst88 , could you help to rebase it?
suppose it still need some time to merge it. the change will be cherry-picked to some other repos to verify whether there are other dependencies need to be removed., then merge it.

@mattst88
Copy link
Contributor Author

Rebased.

Just once I would like to be able to have a contribution to this project accepted without needing to repeatedly ping the PR over multiple months.

@XinfengZhang XinfengZhang added verifying PR: fix ready and verifying with build/test VP Video Processing Encode video encode related Decode video decode related labels Aug 31, 2023
@mattst88
Copy link
Contributor Author

In case it wasn't apparent why removing Gen10 driver code was a good idea, take for example the (now two) cases of people wasting their time fixing Coverity issues in 100% dead code:

commit c1f57e463b924bfed35783b6530e2b86121894ae
Author: pengxin99 <[email protected]>
Date:   Tue Sep 26 13:36:57 2023 +0800

    [Decode] Fix some linux coverity issues

Do you need me to rebase this again?

@Sherry-Lin
Copy link
Contributor

Yes, @mattst88 Would you help rebase again? There is long holiday in coming one week. Please expect the merge after holiday. Thanks.

@mattst88
Copy link
Contributor Author

Rebased.

@mattst88
Copy link
Contributor Author

mattst88 commented Oct 5, 2023

commit c4442ddad7f8a83bcd2d9db24ebfcae5c64531ed
Author: luleilei1 <[email protected]>
Date:   Thu Sep 28 10:25:24 2023 +0800

    Revert "[Decode] Fix some linux coverity issues"
    
    This reverts commit intel-innersource/drivers.gpu.unified#c1f57e463

 media_driver/agnostic/gen10/hw/vdbox/mhw_vdbox_hcp_g10_X.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Seriously? Stop this.

@hanlong1 hanlong1 removed the verifying PR: fix ready and verifying with build/test label Oct 9, 2023
@hanlong1
Copy link
Contributor

Hi @mattst88, can you rebase the change? new conflict happened during verification

Gen10 graphics never shipped, and the support code was disabled by
default in commit 99adba9 ("Disable Gen10 driver code when
-DGEN10=OFF") a few months ago.
@Sherry-Lin Sherry-Lin added the verifying PR: fix ready and verifying with build/test label Oct 11, 2023
@intel-mediadev intel-mediadev merged commit eb14dc9 into intel:master Oct 24, 2023
11 checks passed
@mattst88 mattst88 deleted the delete-gen10 branch October 24, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Decode video decode related Encode video encode related verifying PR: fix ready and verifying with build/test VP Video Processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants