-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gen10 support code #1689
Conversation
Cc: @XinfengZhang |
Anything happening here? |
@mattst88 what's the motivation about the change, it will not impact binary size, only impact the code base size. |
Right. It seems like an obviously good thing for the codebase to remove 340 thousand lines of code that will never be used. |
I love drivers for gen10 gpus. The driver performance and quality is so unbelievable that it can't even be measured. Despite my passion for git repos with a fat line count, though, this MR is obviously the right thing to do. |
@mattst88 , could you help to rebase it? |
Rebased. Just once I would like to be able to have a contribution to this project accepted without needing to repeatedly ping the PR over multiple months. |
In case it wasn't apparent why removing Gen10 driver code was a good idea, take for example the (now two) cases of people wasting their time fixing Coverity issues in 100% dead code:
Do you need me to rebase this again? |
Yes, @mattst88 Would you help rebase again? There is long holiday in coming one week. Please expect the merge after holiday. Thanks. |
51fd4cf
to
43d78e3
Compare
Rebased. |
Seriously? Stop this. |
Hi @mattst88, can you rebase the change? new conflict happened during verification |
Gen10 graphics never shipped, and the support code was disabled by default in commit 99adba9 ("Disable Gen10 driver code when -DGEN10=OFF") a few months ago.
88aca69
to
4879998
Compare
Gen10 graphics never shipped, and the support code was disabled by default in commit 99adba9 ("Disable Gen10 driver code when -DGEN10=OFF") a few months ago.