Skip to content

Commit 74c0147

Browse files
pkwasnie-intelpszymich
authored andcommitted
disable RemoveUnusedIdImplicitArguments by default
Disable RemoveUnusedIdImplicitArguments implicit args optimization by default on all platforms. (cherry picked from commit 4097156)
1 parent c224859 commit 74c0147

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

IGC/Compiler/CISACodeGen/helper.cpp

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3569,17 +3569,7 @@ bool AllowRemovingUnusedImplicitArguments(const CodeGenContext* ctx)
35693569
if (value != TriboolFlag::Default)
35703570
return value == TriboolFlag::Enabled;
35713571

3572-
if (!ctx->platform.supportsZEBin())
3573-
return false;
3574-
3575-
if (ctx->type == ShaderType::OPENCL_SHADER)
3576-
{
3577-
auto* OCLCtx = static_cast<const OpenCLProgramContext*>(ctx);
3578-
if (OCLCtx->m_InternalOptions.PromoteStatelessToBindless && OCLCtx->m_InternalOptions.UseBindlessLegacyMode)
3579-
return false;
3580-
}
3581-
3582-
return ctx->platform.isCoreChildOf(IGFX_XE_HP_CORE);
3572+
return false;
35833573
}
35843574

35853575
} // namespace IGC

IGC/ocloc_tests/features/constant_buffer/noinline.cl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ SPDX-License-Identifier: MIT
1111
// Verify that implicit kernel arguments are not removed for kernels with subroutines.
1212
// Arguments can be removed for stackcalls.
1313

14-
// RUN: ocloc compile -file %s -device pvc -options "-cl-std=CL2.0 -igc_opts 'EnableStackCallFuncCall=0, ShortImplicitPayloadHeader=1, DumpZEInfoToConsole=1'" 2>&1 | FileCheck %s --check-prefix=CHECK-SUBROUTINE
15-
// RUN: ocloc compile -file %s -device pvc -options "-cl-std=CL2.0 -igc_opts 'EnableStackCallFuncCall=1, ShortImplicitPayloadHeader=1, DumpZEInfoToConsole=1'" 2>&1 | FileCheck %s --check-prefix=CHECK-STACKCALL
14+
// RUN: ocloc compile -file %s -device pvc -options "-cl-std=CL2.0 -igc_opts 'EnableStackCallFuncCall=0, ShortImplicitPayloadHeader=1, RemoveUnusedIdImplicitArguments=1, DumpZEInfoToConsole=1'" 2>&1 | FileCheck %s --check-prefix=CHECK-SUBROUTINE
15+
// RUN: ocloc compile -file %s -device pvc -options "-cl-std=CL2.0 -igc_opts 'EnableStackCallFuncCall=1, ShortImplicitPayloadHeader=1, RemoveUnusedIdImplicitArguments=1, DumpZEInfoToConsole=1'" 2>&1 | FileCheck %s --check-prefix=CHECK-STACKCALL
1616

1717
// CHECK-SUBROUTINE: name: kernel_that_must_have_args
1818
// CHECK-SUBROUTINE: payload_arguments:

0 commit comments

Comments
 (0)