Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engineer release on 2023-04-03 #31

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

hao-yao
Copy link
Contributor

@hao-yao hao-yao commented Apr 3, 2023

No description provided.

@hao-yao hao-yao merged commit 82cb8fc into intel:icamerasrc_slim_api Apr 6, 2023
ret = camera_device_open(camerasrc->device_id, camerasrc->num_vc);
#else
ret = camera_device_open(camerasrc->device_id);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho @hao-yao

I'm trying to build the Intel v4l2 drivers to get my MIPI webcam working on Linux, based on instructions on https://github.com/intel/ipu6-drivers repo. I got stuck on a compilation step, which complained about mismatch in number of arguments for camera_device_open().

This PR removed the working version. When I reverted to a commit before this one, the compilation passed.

Here is the header file, which I believe conflicts with the code.
https://github.com/intel/ipu6-camera-hal/blob/main/include/api/ICamera.h#L210

I don't know which one is right (one or two parameters). Since you seems to be making commits to both repos, I will leave the fix for you.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zarnovican ,

Sorry about that. We are refactoring driver internally but we still have some internal releases (except on master/main branch). So currently icamerasrc is not synced with other repos. Please reset icamerasrc to tag:20230307_0904_rpl_plat.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People following the discussion here might be interested in learning that the README from the indicated tag has an instruction to export STRIP_VIRTUAL_CHANNEL_CAMHAL=ON, which does not appear later on anymore.

This setting helps to circumvent the error described in #32 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants