Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NPU]Fix eos_token setting #12475

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[NPU]Fix eos_token setting #12475

merged 2 commits into from
Dec 2, 2024

Conversation

plusbang
Copy link
Contributor

@plusbang plusbang commented Dec 2, 2024 •
edited
Loading

Description

For python (cpp backend), fix eos_token_id setting
Now, n_predict=256 and output is like:
image

4. How to test?

  • Application test

Oscilloscope98
Oscilloscope98 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Oscilloscope98 Oscilloscope98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plusbang plusbang merged commit 54d9a59 into intel-analytics:main Dec 2, 2024
1 check passed
przemekmatusiak pushed a commit to przemekmatusiak/ipex-llm that referenced this pull request Dec 10, 2024
@plusbang @przemekmatusiak
[NPU]Fix eos_token setting (intel-analytics#12475)
fb361d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oscilloscope98 Oscilloscope98 Oscilloscope98 approved these changes

@rnwang04 rnwang04 Awaiting requested review from rnwang04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plusbang @Oscilloscope98