-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NPU] update save-load API usage #12473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-dai
reviewed
Dec 2, 2024
plusbang
force-pushed
the
update-save-load
branch
from
December 2, 2024 08:56
1397294
to
714887e
Compare
plusbang
changed the title
[NPU cpp] update save-load API usage
[NPU] update save-load API usage
Dec 2, 2024
jason-dai
reviewed
Dec 2, 2024
plusbang
force-pushed
the
update-save-load
branch
from
December 2, 2024 09:30
714887e
to
681017d
Compare
rnwang04
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge it first and will add tokenizer save-load processing in examples later. |
przemekmatusiak
pushed a commit
to przemekmatusiak/ipex-llm
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update save-load API usage.
optimize_model=True
, specifysave_directory
is required during the first time to load model, ckpt is saved tosave_directory
after converting.load_low_bit
API to load, and add python cpp backend support2. User API changes
example and benchmark scripts have updated.
4. How to test?