Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout implementation #11

Open
strojank opened this issue Mar 21, 2022 · 1 comment
Open

Timeout implementation #11

strojank opened this issue Mar 21, 2022 · 1 comment

Comments

@strojank
Copy link

Current State

gRPC on Dremio would sometimes fail without returning any response. DremioSource would hang indefinitely.

Proposed

Implementation of a connect_timeout the time allowed to make the initial connection and request_timeout the total timeout for the entire request.

@philippjfr , would that make sense?

@jlstevens
Copy link

jlstevens commented Jun 20, 2022

I see this has been implemented and (I think!) released in 0.23 here. What is still missing though is the ability to set these parameters at the catalog level.

I'll assign @philippjfr as he added the timeouts at the source level already and it should be a quick job to reflect those options at the catalog level.

Edit: Looks like I don't have permissions to assign anyone in this repo! Nevermind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants