-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): Clean up old PEP-249 tests #452
Conversation
eb4a29f
to
8ccf5a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! We should review all the tests and refactor them.
I have one comment only: it's not a big deal, but it's a best practice for readability.
8ccf5a3
to
b1cea7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Use the `unittest` module's `assert` in unit tests. * Drop legacy branching for unsupported 2.7 * Eliminate unused variables * Remove superfluous initializations * Use unpack assignments Signed-off-by: Ferenc Géczi <[email protected]>
Signed-off-by: Ferenc Géczi <[email protected]>
Signed-off-by: Ferenc Géczi <[email protected]>
5f75f21
to
9260e8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Me!
Signed-off-by: Ferenc Géczi <[email protected]>
Signed-off-by: Ferenc Géczi <[email protected]>
9260e8d
to
d884a3d
Compare
unittest
module'sassert
in unit tests.