Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): Clean up old PEP-249 tests #452

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Conversation

Ferenc-
Copy link
Collaborator

@Ferenc- Ferenc- commented Sep 1, 2023

  • Use the unittest module's assert in unit tests.
  • Drop legacy branching for unsupported 2.7
  • Eliminate unused variables
  • Remove superfluous initializations
  • Use unpack assignments

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! We should review all the tests and refactor them.

I have one comment only: it's not a big deal, but it's a best practice for readability.

tests/clients/test_mysqlclient.py Outdated Show resolved Hide resolved
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Use the `unittest` module's `assert` in unit tests.
* Drop legacy branching for unsupported 2.7
* Eliminate unused variables
* Remove superfluous initializations
* Use unpack assignments

Signed-off-by: Ferenc Géczi <[email protected]>
@Ferenc- Ferenc- requested a review from pvital September 4, 2023 17:36
@Ferenc- Ferenc- requested a review from GSVarsha September 5, 2023 08:52
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me!

@Ferenc- Ferenc- merged commit b951f7f into master Sep 6, 2023
2 checks passed
@Ferenc- Ferenc- deleted the test-refactor branch September 6, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants