Add ctx manager tests for pep249 based db modules #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pvital
approved these changes
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
reviewed
Aug 31, 2023
Ferenc-
requested changes
Aug 31, 2023
Ferenc-
requested changes
Aug 31, 2023
There was a problem hiding this comment.
So far this PR is logically one change, which should be revertable and cherry-pick -able in one commit. But it is broken down to two commits. The second is correcting formalities of the first one, which carries the main value. So in the git history we would have to check multiple commits to get to one valuable change.
I suggest to put all these changes here in this case into one commit. Feel free to force push onto PR branches.
And consider make separate commits, if we deliver value separately, and or it makes sense to revert them separately if there is a need.
GSVarsha
force-pushed
the
context_manager_test
branch
from
de9a485 to
2b0c2bc
Compare
Ferenc-
requested changes
Aug 31, 2023
GSVarsha
force-pushed
the
context_manager_test
branch
from
2b0c2bc to
b7dd293
Compare
Signed-off-by: Varsha GS <[email protected]> remove result Signed-off-by: Varsha GS <[email protected]>
GSVarsha
force-pushed
the
context_manager_test
branch
from
b7dd293 to
32818ce
Compare
Accidentally picked the wrong commit during rebase earlier. Should be good now. |
Ferenc-
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add context manager tests to db modules that conform to PEP-249