From e9fbbdaa18963ee684119c30794a7449ec09c8e6 Mon Sep 17 00:00:00 2001 From: Greg Sanders Date: Wed, 24 Jul 2024 16:27:46 -0400 Subject: [PATCH] test: unit tests for CheckEphemeralSpends --- src/test/txvalidation_tests.cpp | 117 ++++++++++++++++++++++++++++++++ 1 file changed, 117 insertions(+) diff --git a/src/test/txvalidation_tests.cpp b/src/test/txvalidation_tests.cpp index 97b27ef3704176..5dafd565c5cd6a 100644 --- a/src/test/txvalidation_tests.cpp +++ b/src/test/txvalidation_tests.cpp @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -89,6 +90,122 @@ static inline CTransactionRef make_tx(const std::vector& inputs, int3 return MakeTransactionRef(mtx); } +// Same as make_tx but adds 2 normal outputs and 0-value dust to end of vout +static inline CTransactionRef make_ephemeral_tx(const std::vector& inputs, int32_t version) +{ + CMutableTransaction mtx = CMutableTransaction{}; + mtx.version = version; + mtx.vin.resize(inputs.size()); + mtx.vout.resize(3); + for (size_t i{0}; i < inputs.size(); ++i) { + mtx.vin[i].prevout = inputs[i]; + } + for (auto i{0}; i < 3; ++i) { + mtx.vout[i].scriptPubKey = CScript() << OP_TRUE; + mtx.vout[i].nValue = (i == 2) ? 0 : 10000; + } + return MakeTransactionRef(mtx); +} + +BOOST_FIXTURE_TEST_CASE(ephemeral_tests, RegTestingSetup) +{ + CTxMemPool& pool = *Assert(m_node.mempool); + LOCK2(cs_main, pool.cs); + TestMemPoolEntryHelper entry; + CTxMemPool::setEntries empty_ancestors; + + CFeeRate minrelay(1000); + + // Basic transaction with dust + auto grandparent_tx_1 = make_ephemeral_tx(random_outpoints(1), /*version=*/2); + const auto dust_txid = grandparent_tx_1->GetHash(); + + uint32_t dust_index = 2; + + // Child transaction spending dust + auto dust_spend = make_tx({COutPoint{dust_txid, dust_index}}, /*version=*/2); + + // We first start with nothing "in the mempool", using package checks + + // Trivial single transaction with no dust + BOOST_CHECK(!CheckEphemeralSpends({dust_spend}, minrelay).has_value()); + BOOST_CHECK(CheckEphemeralSpends({grandparent_tx_1}, minrelay).has_value()); + + // Dust checks pass + BOOST_CHECK(!CheckEphemeralSpends({grandparent_tx_1, dust_spend}, CFeeRate(0)).has_value()); + BOOST_CHECK(!CheckEphemeralSpends({grandparent_tx_1, dust_spend}, minrelay).has_value()); + + auto dust_non_spend = make_tx({COutPoint{dust_txid, dust_index - 1}}, /*version=*/2); + + // Child spending non-dust only from parent should be disallowed even if dust otherwise spent + BOOST_CHECK(CheckEphemeralSpends({grandparent_tx_1, dust_non_spend, dust_spend}, minrelay).has_value()); + BOOST_CHECK(CheckEphemeralSpends({grandparent_tx_1, dust_spend, dust_non_spend}, minrelay).has_value()); + BOOST_CHECK(CheckEphemeralSpends({grandparent_tx_1, dust_non_spend}, minrelay).has_value()); + + auto grandparent_tx_2 = make_ephemeral_tx(random_outpoints(1), /*version=*/2); + const auto dust_txid_2 = grandparent_tx_2->GetHash(); + + // Spend dust from one but not another + BOOST_CHECK(CheckEphemeralSpends({grandparent_tx_1, grandparent_tx_2, dust_spend}, minrelay).has_value()); + + auto dust_non_spend_both_parents = make_tx({COutPoint{dust_txid, dust_index}, COutPoint{dust_txid_2, dust_index - 1}}, /*version=*/2); + BOOST_CHECK(CheckEphemeralSpends({grandparent_tx_1, grandparent_tx_2, dust_non_spend_both_parents}, minrelay).has_value()); + + auto dust_spend_both_parents = make_tx({COutPoint{dust_txid, dust_index}, COutPoint{dust_txid_2, dust_index}}, /*version=*/2); + BOOST_CHECK(!CheckEphemeralSpends({grandparent_tx_1, grandparent_tx_2, dust_spend_both_parents}, minrelay).has_value()); + + // Spending all outputs is also correct + const std::vector all_outpoints{COutPoint(dust_txid, 0), COutPoint(dust_txid, 1), COutPoint(dust_txid, 2), + COutPoint(dust_txid_2, 0), COutPoint(dust_txid_2, 1), COutPoint(dust_txid_2, 2)}; + auto dust_spend_all_outpoints = make_tx(all_outpoints, /*version=*/2); + BOOST_CHECK(!CheckEphemeralSpends({grandparent_tx_1, grandparent_tx_2, dust_spend_all_outpoints}, minrelay).has_value()); + + // 2 grandparents with dust <- 1 dust-spending parent with dust <- child with no dust + auto parent_with_dust = make_ephemeral_tx({COutPoint{dust_txid, dust_index}, COutPoint{dust_txid_2, dust_index}}, /*version=*/2); + BOOST_CHECK(CheckEphemeralSpends({grandparent_tx_1, grandparent_tx_2, parent_with_dust}, minrelay).has_value()); + auto child_no_dust = make_tx({COutPoint{parent_with_dust->GetHash(), dust_index}}, /*version=*/2); + BOOST_CHECK(!CheckEphemeralSpends({grandparent_tx_1, grandparent_tx_2, parent_with_dust, child_no_dust}, minrelay).has_value()); + + // 2 grandparents with dust <- 1 dust-spending parent with dust <- child with dust + auto child_with_dust = make_ephemeral_tx({COutPoint{parent_with_dust->GetHash(), dust_index}}, /*version=*/2); + BOOST_CHECK(CheckEphemeralSpends({grandparent_tx_1, grandparent_tx_2, parent_with_dust, child_with_dust}, minrelay).has_value()); + + // Tests for PreChecks-based checks + + // Empty ancestors means this should never fail since it only checks parents' dust + BOOST_CHECK(!CheckEphemeralSpends(grandparent_tx_1, empty_ancestors, minrelay).has_value()); + + // Add first grandparent to mempool and fetch entry + pool.addUnchecked(entry.FromTx(grandparent_tx_1)); + const auto grandparent_entry_1 = pool.GetIter(grandparent_tx_1->GetHash().ToUint256()).value(); + + // Ignores ancestors that aren't direct parents + BOOST_CHECK(!CheckEphemeralSpends(child_no_dust, {grandparent_entry_1}, minrelay).has_value()); + + // Valid spend of dust with grandparent in mempool + BOOST_CHECK(!CheckEphemeralSpends(parent_with_dust, {grandparent_entry_1}, minrelay).has_value()); + + // Add second grandparent + pool.addUnchecked(entry.FromTx(grandparent_tx_2)); + + const auto grandparent_entry_2 = pool.GetIter(grandparent_tx_2->GetHash().ToUint256()).value(); + CTxMemPool::setEntries grandparent_entries{grandparent_entry_1, grandparent_entry_2}; + + // Only spends single dust out of two direct parents + BOOST_CHECK(CheckEphemeralSpends(dust_non_spend_both_parents, grandparent_entries, minrelay).has_value()); + + // Spends both parents' dust + BOOST_CHECK(!CheckEphemeralSpends(parent_with_dust, grandparent_entries, minrelay).has_value()); + + // Now add dusty parent to mempool + pool.addUnchecked(entry.FromTx(parent_with_dust)); + const auto parent_entry = pool.GetIter(parent_with_dust->GetHash().ToUint256()).value(); + CTxMemPool::setEntries all_entries{grandparent_entry_1, grandparent_entry_2, parent_entry}; + + // Passes dust checks even with non-parent ancestors + BOOST_CHECK(!CheckEphemeralSpends(child_no_dust, all_entries, minrelay).has_value()); +} + BOOST_FIXTURE_TEST_CASE(version3_tests, RegTestingSetup) { // Test TRUC policy helper functions