Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

Improve messages in custom validators #231

Open
jmartinm opened this issue Oct 4, 2017 · 2 comments
Open

Improve messages in custom validators #231

jmartinm opened this issue Oct 4, 2017 · 2 comments

Comments

@jmartinm
Copy link
Contributor

jmartinm commented Oct 4, 2017

Custom validators are defined https://github.com/inspirehep/record-editor/blob/master/src/app/shared/services/app-config.service.ts#L510-L512

If, for example a date is wrong, the message: "Should match format 'date'" is displayed, which is not useful to know which formats are allowed.

An improvement would be to able to customize these messages.

@harunurhan
Copy link
Collaborator

Blocked by this inveniosoftware-contrib/ng2-json-editor#417

@harunurhan
Copy link
Collaborator

this is was unblocked while ago, I just realized. If you post list of validations error messages to configure and what to put instead of the default one, I'll add them to configurations.
@jmartinm @StellaCh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants