Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-enhancement: automatically set 'citeable=True' #173

Open
fschwenn opened this issue Sep 1, 2017 · 5 comments
Open

post-enhancement: automatically set 'citeable=True' #173

fschwenn opened this issue Sep 1, 2017 · 5 comments

Comments

@fschwenn
Copy link
Contributor

fschwenn commented Sep 1, 2017

Create a workflow task to (in case) add 'citeable=True' which could be added to POSTENHANCE_RECORD for HEP records.

Expected Behavior

That task would check whether record has DOI, report number or pubnote and then sets citeable=True.

Context

Instead of checking it in each spider, user suggestion or BibEdit, one central place should be used for that task.

@annetteholtkamp
Copy link

annetteholtkamp commented Sep 1, 2017 via email

@fschwenn
Copy link
Contributor Author

fschwenn commented Sep 1, 2017

@annetteholtkamp
Copy link

annetteholtkamp commented Sep 1, 2017 via email

@michamos
Copy link
Contributor

michamos commented Sep 1, 2017

this is currently already implemented partially in the literature builder in https://github.com/inspirehep/inspire-schemas/blob/36bb1791b4df5890e5445f850c59ed9c5ee9b7c9/inspire_schemas/builders/literature.py#L171 and https://github.com/inspirehep/inspire-schemas/blob/36bb1791b4df5890e5445f850c59ed9c5ee9b7c9/inspire_schemas/builders/literature.py#L415-L416 for arXiv and publication info respectively (I didn't know about that page either). So if at record creation time there is enough information to make a paper citeable, it is automatically flagged as citeable. This includes user suggestions and hepcrawl harvests (both new and updates), but excludes the case where a curator modification in the record editor would make a record (non-)citeable.

@fschwenn
Copy link
Contributor Author

fschwenn commented Sep 1, 2017

Neither do I remember that we agreed on RNs and DOIs - but I missed quite some standups, so I checked the training pages thinking they would reflect the agreed status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants