fix(get_hydrometrie_observations_tr): crashes when returns empty result

DDorch · DDorch · commit 006610dd4d08 · 2024-12-01T14:07:42.000+01:00
Closes #47
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -48,4 +48,4 @@ Encoding: UTF-8
 Language: en-US
 LazyData: true
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
diff --git a/R/get_hydrometrie.R b/R/get_hydrometrie.R
@@ -64,7 +64,7 @@ get_hydrometrie_observations_tr  <- function(...,
     endpoint = "observations_tr",
     ...
   )
-  if(!is.null(l)) {
+  if (length(l) > 0) {
     l <- lapply(l, function(x) {
       if (entities == "station") {
         if (is.null(x$code_station)) {
@@ -78,9 +78,8 @@ get_hydrometrie_observations_tr  <- function(...,
       return(x)
     })
     l[sapply(l, is.null)] <- NULL
-    l <- convert_list_to_tibble(l)
   }
-  return(l)
+  return(convert_list_to_tibble(l))
 }
 
 
diff --git a/tests/testthat/test-run_all_examples.R b/tests/testthat/test-run_all_examples.R
@@ -25,5 +25,3 @@ lapply(db, function(Rd_fun) {
     })
   }
 })
-
-

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ get_hydrometrie_observations_tr <- function(...,`
`64`	`64`	`endpoint = "observations_tr",`
`65`	`65`	`...`
`66`	`66`	`)`
`67`		`- if(!is.null(l)) {`
	`67`	`+ if (length(l) > 0) {`
`68`	`68`	`l <- lapply(l, function(x) {`
`69`	`69`	`if (entities == "station") {`
`70`	`70`	`if (is.null(x$code_station)) {`
`@@ -78,9 +78,8 @@ get_hydrometrie_observations_tr <- function(...,`
`78`	`78`	`return(x)`
`79`	`79`	`})`
`80`	`80`	`l[sapply(l, is.null)] <- NULL`
`81`		`- l <- convert_list_to_tibble(l)`
`82`	`81`	`}`
`83`		`- return(l)`
	`82`	`+ return(convert_list_to_tibble(l))`
`84`	`83`	`}`
`85`	`84`
`86`	`85`