signTx's TransactionWitnessSet produce TextEnvelope decode error in cardano-cli

[jinglescode]

@alessandrokonrad . For cardano.signTx(), the output TransactionWitnessSet, does not tally the input required in cardano-cli, producing this error:

Command failed: transaction sign-witness  Error: buyer_witness_set_from_nami_signTx.witness: TextEnvelope decode error: DecoderErrorDeserialiseFailure "Shelley Witness" (DeserialiseFailure 0 "expected list len")

Seems like, the cborHex Nami produced after signTx() has extra 2 characters.

[alessandrokonrad]

What function are you using the cardano-cli? The TransactionWitnessSet is a wrapper around the actual vkey witness. I haven't tried it in the cli yet, but it's definitely correct what Nami returns you. It's based on top of the serialization-lib.

[jinglescode]

@alessandrokonrad thanks for you reply. Using cardanoo-cli transaction assemble I'm combining the cbor taken from TransactionWitnessSet taken from cardano.signTx(), adding the cbor into a file that looks like that:

{
    "type": "TxWitness MaryEra",
    "description": "",
    "cborHex": "CBOR TAKEN FROM TransactionWitnessSet"
}

With cardanoo-cli transaction assemble, adding other witnesses generated by cardano cli transaction witness.

[rooooooooob]

it's possibly related to IntersectMBO/cardano-node#3370 but I haven't looked into it so it might be unrelated since that issue was from cardano-cli -> cardano-serialization-lib not the other way around

[jinglescode]

it's possibly related to input-output-hk/cardano-node#3370 but I haven't looked into it so it might be unrelated since that issue was from cardano-cli -> cardano-serialization-lib not the other way around

Hi @rooooooooob, any workaround on this? I'm implementing partial signing as described here.

After executing, cardano.signTx(tx, partialSign=true), the hex encoded cbor string I got from TransactionWitnessSet; can I copy the cbor string into this .witness file with the follow format?:

{
    "type": "TxWitness MaryEra",
    "description": "",
    "cborHex": "CBOR TAKEN FROM TransactionWitnessSet"
}

Do I have to manipulate the cbor string first? Does the TransactionWitnessSet cbor from the serialization library match the required input from cardano-cli?

And lastly using cardano-cli transaction assemble:

cardano-cli transaction assemble     
--tx-body-file tx.draft     
--witness-file transaction_witness_generated_by_cli.witness 
--witness-file transaction_witness_from_above_json_file.witness      
--out-file tx.signed

Error I'm getting:

TextEnvelope decode error: DecoderErrorDeserialiseFailure "Shelley Witness" (DeserialiseFailure 0 "expected list len")

[pyropy]

@jinglescode Have you managed to assemble those two transactions in the end?

[rooooooooob]

@jinglescode can you please post the output (hex string for cbor or whatever format it's in) from the CLI that you're trying to parse?

[pyropy]

I've managed to assemble witness returned from nami and tx built from cli.

What you need to do is to take vkeys and wrap them in array like so [0, [vkeys]] and then encode it to cbor once again.

[jinglescode]

I've managed to assemble witness returned from nami and tx built from cli.

What you need to do is to take vkeys and wrap them in array like so [0, [vkeys]] and then encode it to cbor once again.

I tried that, and this is how it looks like.

window.cardano.signTx(cborHex, true).then((signedTx) => {

  const array_to_cli = []; // to create `[0, [vkeys]]`
  array_to_cli.push(0);

  const decoded = cbor.decode(signedTx);
  for (let i of decoded) {
    array_to_cli.push(i);
  }

  const signed_cbor_from_nami = cbor.encode(array_to_cli).toString('hex');
});

Put signed_cbor_from_nami into the witness file, so cardano-cli can consume:

{
    "type": "TxWitness MaryEra",
    "description": "",
    "cborHex": "CBOR TAKEN FROM signed_cbor_from_nami"
}

And then:

Command failed: transaction sign-witness  Error: buyer_witness_set_from_nami_signTx.witness: TextEnvelope decode error: DecoderErrorDeserialiseFailure "Shelley Witness" (DeserialiseFailure 0 "expected list len")

What I'm doing wrong here? Any advice will be helpful.

[pyropy]

@jinglescode You actually get keywitness-set returned when signing transaction that holds vkeys, which are needed to assemble witness object. Here's an example:

  const encodedTxVkeyWitnesses = await wallet.signTx(encodedTx, true);

  const txVkeyWitnesses = wasm.TransactionWitnessSet.from_bytes(
    Buffer.from(encodedTxVkeyWitnesses, "hex")
  );

  // extract vkeys from witness set as bytes
  const vkeysBytes = Buffer.from(
      txVkeyWitnesses.vkeys()?.get(0).to_bytes() as Uint8Array
    ).toString('hex');


  const vkeysDecoded = cbor.decode(vkeysBytes)
  const witness = [0, vkeysDecoded]
  const witnessCbor = cbor.encode(witness)

[rooooooooob]

@pyropy

What you need to do is to take vkeys and wrap them in array like so [0, [vkeys]] and then encode it to cbor once again.

With both being arrays? In alzono.cddl we have

transaction_witness_set =
  { ? 0: [* vkeywitness ]
  , ? 1: [* native_script ]
  , ? 2: [* bootstrap_witness ]
  , ? 3: [* plutus_script ] ;New
  , ? 4: [* plutus_data ] ;New
  , ? 5: [* redeemer ] ;New
  }

which should be a map not an array. In the cardano-serialization-lib we implemented off the binary spec which implements it as a map not an array.

Can someone please post CBOR (can be hex string or whatever format you can post here) of what is working and what isn't working so I can look into it? It seems to me like it's just map vs array but I would like to examine the CBOR see if that's the only difference. Thanks.

[jinglescode]

Edit:

Hey @rooooooooob, here is the CBOR from cardano.signTx(encodedTx, true) after applying @pyropy method:
82008258209b8e0e4205180b4a2ac3511b39435e7e472c6cd817c1f05aaa7545c4b816601a584036b135996644821b84ccd31ad0b8ee07ef9b16eca8046aec96e8e756c0fcef293aeb0cd78866823239de10f98e5f9ddf223b814aaf2140183777d4fc742a3009

This works!