Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize Cardano Transaction prover #1781

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Parallelize Cardano Transaction prover #1781

wants to merge 3 commits into from
+27 −15

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 26, 2024 •
edited
Loading

Content

This PR parallelization of the Cardano transaction prover:

  • The proof computation by the Merkle map
  • The block ranges sub Merkle tree computation

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1756

@jpraynaud jpraynaud self-assigned this Jun 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

Test Results

    4 files  ±0     51 suites  ±0   8m 45s ⏱️ -3s
1 101 tests ±0  1 101 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 249 runs  ±0  1 249 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c72928d. ± Comparison against base commit ed03ede.

♻️ This comment has been updated with latest results.

sfauvel
sfauvel approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just some proposition to simply code

mithril-common/src/crypto_helper/merkle_map.rs Show resolved Hide resolved
@jpraynaud
feat: parallelize Cardano transaction prover
3670961 
Add parallel computation of the Merkle trees of block ranges to proof from.
@jpraynaud
feat: parallelize Merkle map proof computation
e358321 
Add parallel computation for inner proof computation.
@jpraynaud
refactor: simplify sub proof computations in Merkle map
c72928d
@jpraynaud jpraynaud force-pushed the jpraynaud/1756-parallelize-cardano-tx-prover branch from 00a49c7 to c72928d Compare July 1, 2024 10:19
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 1, 2024 10:26 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize Cardano transaction prover performances with parallelization
2 participants
@jpraynaud @sfauvel