Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add static-analysis-js.yml #159

Merged
merged 7 commits into from
Sep 18, 2024
Merged

feat: add static-analysis-js.yml #159

merged 7 commits into from
Sep 18, 2024

Conversation

shvlv
Copy link
Contributor

@shvlv shvlv commented Sep 17, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.

What is the current behavior? (You can also link to an open issue here)
#63

What is the new behavior (if this is a feature change)?
A new workflow to perform static analysis for Javascript.

Example of the output:
image

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No. The new workflow can be run only with NPM.

Other information:

@shvlv shvlv linked an issue Sep 17, 2024 that may be closed by this pull request
1 task
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this. I left a couple of comments, as usual. 😉

.github/workflows/static-analysis-js.yml Outdated Show resolved Hide resolved
.github/workflows/static-analysis-js.yml Outdated Show resolved Hide resolved
docs/js.md Outdated Show resolved Hide resolved
docs/js.md Outdated Show resolved Hide resolved
docs/js.md Outdated Show resolved Hide resolved
docs/js.md Outdated Show resolved Hide resolved
docs/js.md Outdated Show resolved Hide resolved
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! LGTM. 🙏🏽

@shvlv shvlv merged commit 1d33ebd into main Sep 18, 2024
1 check passed
@shvlv shvlv deleted the static-analysis-js branch September 18, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Check TypeScript types
2 participants