Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --no-discovery #181

Open
Tobbe opened this issue Jul 30, 2023 · 2 comments
Open

Use --no-discovery #181

Tobbe opened this issue Jul 30, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@Tobbe
Copy link

Tobbe commented Jul 30, 2023

Inngest's dev server automatically tries to find apps to connect to on a bunch of different ports and paths.

With RW we know exactly what url to connect to, so we can disable automatic discovery to limit spam in api-side console logs.
Disable discovery by passing --no-discovery to the inngest-cli command.

@dthyresson
Copy link
Collaborator

Thanks @Tobbe - I've seen and been asked about the requests the dev server makes to discover functions and since they can appear like api request errors in RedwoodJS logs it's misleading and makes the DX less confident.

I also see a "no-polling" https://github.com/inngest/inngest/blob/d5d756791631b9d25e0f31dc1f7190480456bbeb/cmd/commands/dev.go#L26 flags which I think could resolve the questions I've gotten about a less that great experience when either your app or dev server isn't up.

I imagine the downside would be that the dev server would have to be restarted perhaps when new functions are added?

@dthyresson dthyresson self-assigned this Jul 30, 2023
@dthyresson dthyresson added enhancement New feature or request good first issue Good for newcomers documentation Improvements or additions to documentation labels Jul 30, 2023
@dthyresson
Copy link
Collaborator

Also, the setup readme should note these two dev server flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants