Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with the opening of TCP ports for inlets-pro on GCE #44

Closed
utsavanand2 opened this issue Feb 3, 2020 · 4 comments · Fixed by #58
Closed

Fix issue with the opening of TCP ports for inlets-pro on GCE #44

utsavanand2 opened this issue Feb 3, 2020 · 4 comments · Fixed by #58

Comments

@utsavanand2
Copy link
Contributor

utsavanand2 commented Feb 3, 2020

Expected Behaviour

The GCE operator should open up ports for inlets-pro
For users switching between inlets OSS and inlets-pro, the firewall rules should be
updated automatically.

Current Behaviour

If a firewall rule named inlets for inlets OSS already exists, it doesn't open up ports for inlets-pro

Possible Solution

PR #45

Steps to Reproduce (for bugs)

  1. Run inletsctl with inlets OSS
  2. Run inletsctl again with inlets-pro
utsavanand2 added a commit to utsavanand2/inletsctl that referenced this issue Feb 3, 2020
Fix issue with the opening of TCP ports for inlets-pro on GCE

The --rm flag will enable to point to
an upstream or a remote-tcp and will delete the exit-node
on a SIGINT (control + c)
Updates the firewall rule when switching between inlets OSS
and inlets-pro and opens up ports from 1024 to 65535 when using
inlets-pro.

Fixes inlets#41
Fixes inlets#44

Signed-off-by: Utsav Anand <[email protected]>
@alexellis
Copy link
Member

To be fair this isn't going to work. We need all ports to be opened. cc @adamjohnson01

The point of inlets-pro is that it's a pass-through TCP proxy, so we'd want ports as low as 22, 80 and 443 if that's what the user was punching out.

@utsavanand2
Copy link
Contributor Author

utsavanand2 commented Feb 3, 2020 via email

@utsavanand2
Copy link
Contributor Author

@alexellis Do you want any other ports to be opened apart from these?

utsavanand2 added a commit to utsavanand2/inletsctl that referenced this issue Feb 3, 2020
Fix issue with the opening of TCP ports for inlets-pro on GCE

The --rm flag will enable to point to
an upstream or a remote-tcp and will delete the exit-node
on a SIGINT (control + c)
Updates the firewall rule when switching between inlets OSS
and inlets-pro and opens up ports from 1024 to 65535 when using
inlets-pro.

Fixes inlets#41
Fixes inlets#44

Signed-off-by: Utsav Anand <[email protected]>
utsavanand2 added a commit to utsavanand2/inletsctl that referenced this issue Feb 3, 2020
Fix issue with the opening of TCP ports for inlets-pro on GCE

The --rm flag will enable to point to
an upstream or a remote-tcp and will delete the exit-node
on a SIGINT (control + c)
Updates the firewall rule when switching between inlets OSS
and inlets-pro and opens up ports from 1024 to 65535 when using
inlets-pro.

Fixes inlets#41
Fixes inlets#44

Signed-off-by: Utsav Anand <[email protected]>
@utsavanand2
Copy link
Contributor Author

utsavanand2 commented Feb 9, 2020

Update: The linked PR #58 will open up all TCP traffic
cc @alexellis

utsavanand2 added a commit to utsavanand2/inletsctl that referenced this issue Feb 9, 2020
This PR will now allow for all TCP traffic through
the inlets-pro exit node
If a firewall-rule for inlets or inlets-pro named 'inlets' already
exists, then it will update the firewall-rule with the
required rules depending on the user using the `--remote-tcp`
flag (inlets-pro) or not in `inletsctl create` command

Fixes inlets#44
Fixes inlets#56

Signed-off-by: Utsav Anand <[email protected]>
utsavanand2 added a commit to utsavanand2/inletsctl that referenced this issue Feb 9, 2020
This PR will now allow for all TCP traffic through
the inlets-pro exit node
If a firewall-rule for inlets or inlets-pro named 'inlets' already
exists, then it will update the firewall-rule with the
required rules depending on the user using the `--remote-tcp`
flag (inlets-pro) or not in `inletsctl create` command

Fixes inlets#44
Fixes inlets#56

Signed-off-by: Utsav Anand <[email protected]>
alexellis pushed a commit that referenced this issue Feb 9, 2020
This PR will now allow for all TCP traffic through
the inlets-pro exit node
If a firewall-rule for inlets or inlets-pro named 'inlets' already
exists, then it will update the firewall-rule with the
required rules depending on the user using the `--remote-tcp`
flag (inlets-pro) or not in `inletsctl create` command

Fixes #44
Fixes #56

Signed-off-by: Utsav Anand <[email protected]>
zechen0 pushed a commit to zechen0/inletsctl that referenced this issue Feb 25, 2020
This PR will now allow for all TCP traffic through
the inlets-pro exit node
If a firewall-rule for inlets or inlets-pro named 'inlets' already
exists, then it will update the firewall-rule with the
required rules depending on the user using the `--remote-tcp`
flag (inlets-pro) or not in `inletsctl create` command

Fixes inlets#44
Fixes inlets#56

Signed-off-by: Utsav Anand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants