-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with the opening of TCP ports for inlets-pro on GCE #44
Comments
utsavanand2
added a commit
to utsavanand2/inletsctl
that referenced
this issue
Feb 3, 2020
Fix issue with the opening of TCP ports for inlets-pro on GCE The --rm flag will enable to point to an upstream or a remote-tcp and will delete the exit-node on a SIGINT (control + c) Updates the firewall rule when switching between inlets OSS and inlets-pro and opens up ports from 1024 to 65535 when using inlets-pro. Fixes inlets#41 Fixes inlets#44 Signed-off-by: Utsav Anand <[email protected]>
To be fair this isn't going to work. We need all ports to be opened. cc @adamjohnson01 The point of inlets-pro is that it's a pass-through TCP proxy, so we'd want ports as low as 22, 80 and 443 if that's what the user was punching out. |
My PR will be opening 22, 80, 443, and ports from 1024 to 65535
…On Mon, Feb 3, 2020, 9:03 PM Alex Ellis ***@***.***> wrote:
To be fair this isn't going to work. We need all ports to be opened. cc
@adamjohnson01 <https://github.com/adamjohnson01>
The point of inlets-pro is that it's a pass-through TCP proxy, so we'd
want ports as low as 22, 80 and 443 if that's what the user was punching
out.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44?email_source=notifications&email_token=AGAYDRMBDYMOCOKSCLVNHCLRBA2NVA5CNFSM4KPHFM52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUIWUI#issuecomment-581471057>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGAYDRPBVMP2Y4PR5A2PB43RBA2NVANCNFSM4KPHFM5Q>
.
|
@alexellis Do you want any other ports to be opened apart from these? |
utsavanand2
added a commit
to utsavanand2/inletsctl
that referenced
this issue
Feb 3, 2020
Fix issue with the opening of TCP ports for inlets-pro on GCE The --rm flag will enable to point to an upstream or a remote-tcp and will delete the exit-node on a SIGINT (control + c) Updates the firewall rule when switching between inlets OSS and inlets-pro and opens up ports from 1024 to 65535 when using inlets-pro. Fixes inlets#41 Fixes inlets#44 Signed-off-by: Utsav Anand <[email protected]>
utsavanand2
added a commit
to utsavanand2/inletsctl
that referenced
this issue
Feb 3, 2020
Fix issue with the opening of TCP ports for inlets-pro on GCE The --rm flag will enable to point to an upstream or a remote-tcp and will delete the exit-node on a SIGINT (control + c) Updates the firewall rule when switching between inlets OSS and inlets-pro and opens up ports from 1024 to 65535 when using inlets-pro. Fixes inlets#41 Fixes inlets#44 Signed-off-by: Utsav Anand <[email protected]>
Update: The linked PR #58 will open up all TCP traffic |
utsavanand2
added a commit
to utsavanand2/inletsctl
that referenced
this issue
Feb 9, 2020
This PR will now allow for all TCP traffic through the inlets-pro exit node If a firewall-rule for inlets or inlets-pro named 'inlets' already exists, then it will update the firewall-rule with the required rules depending on the user using the `--remote-tcp` flag (inlets-pro) or not in `inletsctl create` command Fixes inlets#44 Fixes inlets#56 Signed-off-by: Utsav Anand <[email protected]>
4 tasks
utsavanand2
added a commit
to utsavanand2/inletsctl
that referenced
this issue
Feb 9, 2020
This PR will now allow for all TCP traffic through the inlets-pro exit node If a firewall-rule for inlets or inlets-pro named 'inlets' already exists, then it will update the firewall-rule with the required rules depending on the user using the `--remote-tcp` flag (inlets-pro) or not in `inletsctl create` command Fixes inlets#44 Fixes inlets#56 Signed-off-by: Utsav Anand <[email protected]>
alexellis
pushed a commit
that referenced
this issue
Feb 9, 2020
This PR will now allow for all TCP traffic through the inlets-pro exit node If a firewall-rule for inlets or inlets-pro named 'inlets' already exists, then it will update the firewall-rule with the required rules depending on the user using the `--remote-tcp` flag (inlets-pro) or not in `inletsctl create` command Fixes #44 Fixes #56 Signed-off-by: Utsav Anand <[email protected]>
zechen0
pushed a commit
to zechen0/inletsctl
that referenced
this issue
Feb 25, 2020
This PR will now allow for all TCP traffic through the inlets-pro exit node If a firewall-rule for inlets or inlets-pro named 'inlets' already exists, then it will update the firewall-rule with the required rules depending on the user using the `--remote-tcp` flag (inlets-pro) or not in `inletsctl create` command Fixes inlets#44 Fixes inlets#56 Signed-off-by: Utsav Anand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behaviour
The GCE operator should open up ports for inlets-pro
For users switching between inlets OSS and inlets-pro, the firewall rules should be
updated automatically.
Current Behaviour
If a firewall rule named inlets for inlets OSS already exists, it doesn't open up ports for inlets-pro
Possible Solution
PR #45
Steps to Reproduce (for bugs)
The text was updated successfully, but these errors were encountered: