Add --static-file flag to create a static file #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR adds feature to create a static file with the machine ID, auth, IP and other metadata when the `--static-file` flag is passed Closes inlets#28 Signed-off-by: Utsav Anand <[email protected]>
alexellis
reviewed
Mar 19, 2020
| @@ -44,6 +49,7 @@ func init() { | |||
| createCmd.Flags().StringP("remote-tcp", "c", "", `Remote host for inlets-pro to use for forwarding TCP connections`) | |||
|
|
|||
| createCmd.Flags().DurationP("poll", "n", time.Second*2, "poll every N seconds, use a higher value if you encounter rate-limiting") | |||
| createCmd.Flags().BoolVarP(&staticFile, "static-file", "", false, "Create a static file for the provisioned machine") | |||
There was a problem hiding this comment.
I'm having second thoughts on the naming.
--static-file is rather verbose and we should have a shortcut for it too like we have -c for --remote-tcp
What other ideas do you have? cc @Waterdrips
There was a problem hiding this comment.
@alexellis @Waterdrips Maybe --sf ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --static-file flag to create a static file
Signed-off-by: Utsav Anand [email protected]
Description
The PR adds feature to create a static file with the
machine ID, auth, IP and other metadata when the
--static-fileflag is passed
Closes #28
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
No user impact
Checklist:
I have:
git commit -s