Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurp seems to have stopped working today #50

Open
davidberreby opened this issue Jul 16, 2024 · 2 comments
Open

Slurp seems to have stopped working today #50

davidberreby opened this issue Jul 16, 2024 · 2 comments
Labels
bug Something isn't working parsing issue Problems related to Readability or Obsidian's Turndown implementation unsupported-site Sites that reject requests from Slurp or use scripts that prevent Slurp from working

Comments

@davidberreby
Copy link

Hi,
Obsidian 1.6.5 on a Macbook Air M3 running Sonoma -- Slurp throws up errors.

URLs that failed:

https://www.breastcancer.org/research-news/men-at-high-risk-benefit-from-mammograms

https://coned-findacontractor.icfsightline.com/

One URL -- a New York Times news story -- went through.

@inhumantsar
Copy link
Owner

Firefox is able to parse the breastcancer.org link using Readability. breastcancer.org might be blocking requests from scripts like Slurp, i've seen that before with other sites. there also might be something off in the preparsing steps. i'll take a look this weekend and see what's up.

the icfsightline page is a type that often isn't parseable by Slurp. pages that dynamically load information or don't contain much text generally can't be parsed since slurp can't operate a form, run javascript, or simplify a page that doesn't have information to simplify. i'll have a look at it as well, but i'm fairly certain it's simply not compatible.

i'll also have a look at improving that error message to better indicate when a page is simply incompatible.

thanks for the report!

@inhumantsar inhumantsar added bug Something isn't working parsing issue Problems related to Readability or Obsidian's Turndown implementation labels Jul 19, 2024
@davidberreby
Copy link
Author

davidberreby commented Jul 20, 2024 via email

@inhumantsar inhumantsar added the unsupported-site Sites that reject requests from Slurp or use scripts that prevent Slurp from working label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parsing issue Problems related to Readability or Obsidian's Turndown implementation unsupported-site Sites that reject requests from Slurp or use scripts that prevent Slurp from working
Projects
None yet
Development

No branches or pull requests

2 participants