Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: save images locally #45

Open
nathonius opened this issue Jun 4, 2024 · 4 comments
Open

Feature request: save images locally #45

nathonius opened this issue Jun 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@nathonius
Copy link

nathonius commented Jun 4, 2024

Currently the plugin links to the remote images from where they were slurped. It would be great to have an option to save the images alongside the markdown for eventual case where the url changes or the content is removed.

Since this is using almost the same stack as MarkdownDown and produces nearly identical output, I'm assuming you'll run into the same issue I created (from another GitHub account) for that project: asadm/markdowndown#2

If this is out of scope for the plugin, I would look into using the hooks described in #37 to write a companion plugin myself. 😃

@inhumantsar
Copy link
Owner

thanks! I like this idea. any thoughts on how images should be organized? I normally keep images for obsidian md files in a subdir called _files, not sure how others handle them though

@Truncated
Copy link

I use Local Images Plus to automatically process images from slurped content. It works a treat on Slurped results.
https://github.com/Sergei-Korneev/obsidian-local-images-plus

As of this writing...
It addresses:

  • Leaving the original link name in the content, while changing the file name for your records.
  • Option to generate file names as MD5 Hash to avoid name collisions
  • Can convert PNG to JPEG if that's your jam
  • Manage Media folder target and naming with some amount of variables.

It does not address :

  • No deduplication options if you're not using the MD5 + same save location.
  • Huge files will choke it, but that feels like a fringe case for most.
  • No specific conversions for WEBP.

@inhumantsar inhumantsar added the enhancement New feature or request label Jun 8, 2024
@inhumantsar
Copy link
Owner

ooo, i'll look into adding an option to call that automatically after writing the file. that would definitely simplify things.

@nathonius
Copy link
Author

Yeah, adding in a post-process hook to do that (or any other command 👀) would be fantastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants