Allow AWS provider v4, add rspec-terraform, add unit tests, add rubocop.

Author: tobyclemson

.circleci/config.yml

@@ -85,7 +85,11 @@ jobs:
     steps:
       - checkout
       - configure_tools
-      - run: ./scripts/ci/steps/test.sh
+      - run:
+          no_output_timeout: 30m
+          command: ./scripts/ci/steps/test.sh
+      - store_artifacts:
+          path: build/logs
       - notify
 
   prerelease:

.envrc

@@ -2,5 +2,5 @@
 
 PROJECT_DIR="$(pwd)"
 
-PATH_add ${PROJECT_DIR}
-PATH_add ${PROJECT_DIR}/vendor/terraform/bin
+PATH_add "${PROJECT_DIR}"
+PATH_add "${PROJECT_DIR}"/vendor/terraform/bin

.gitignore

@@ -12,6 +12,7 @@
 vendor/
 build/
 dist/
+.bundle
 .rakeTasks
 
 # OS
@@ -27,6 +28,8 @@ run/logs/
 .rspec_status
 
 # Terraform
+state/
 .terraform
+*.tfplan
 *.tfstate
 *.tfstate.backup

.rubocop.yml

@@ -9,7 +9,7 @@ Layout/LineLength:
   Max: 80
 
 Metrics/BlockLength:
-  IgnoredMethods:
+  AllowedMethods:
     - describe
     - context
     - shared_examples
@@ -26,6 +26,9 @@ RSpec/ExampleLength:
 RSpec/DescribeClass:
   Enabled: false
 
+RSpec/InstanceVariable:
+  Enabled: false
+
 RSpec/BeforeAfterAll:
   Enabled: false
 

Gemfile

@@ -14,6 +14,7 @@ gem 'rake_gpg'
 gem 'rake_ssh'
 gem 'rake_terraform'
 gem 'rspec'
+gem 'rspec-terraform'
 gem 'rubocop'
 gem 'rubocop-rake'
 gem 'rubocop-rspec'