Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate / remove channel_set_id from SendSatelliteCommandsRequest #284

Open
danada opened this issue Jul 6, 2021 · 0 comments
Open

Deprecate / remove channel_set_id from SendSatelliteCommandsRequest #284

danada opened this issue Jul 6, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@danada
Copy link
Contributor

danada commented Jul 6, 2021

The intention of this field was to differentiate which channel set to use when commanding a satellite engaged with multiple ground stations at the same time. Since we are moving towards per-plan streams, the plan ID is enough information to determine which ground station to forward commands to.

Since this field was never implemented server-side and is marked as alpha, it should be relatively safe to remove without a deprecation step on the server.

@danada danada added the good first issue Good for newcomers label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant