Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: Remove value_payload option from the config #835

Open
romac opened this issue Feb 6, 2025 · 0 comments
Open

code: Remove value_payload option from the config #835

romac opened this issue Feb 6, 2025 · 0 comments
Labels
code Code/implementation related configuration Configuration of the node good first issue Good for newcomers
Milestone
Phase 5

Comments

@romac
Copy link
Member

romac commented Feb 6, 2025

I think we should remove the value_payload from the consensus config and instead pass this down from the app. The app itself may hardcode this or, if we want to test multiple options from a test app, we make it part of the app config, controlled by tests.

Originally posted by @ancazamfir in #819 (comment)
@romac romac added good first issue Good for newcomers code Code/implementation related configuration Configuration of the node labels Feb 6, 2025
@romac romac added this to the Phase 5 milestone Feb 6, 2025
@romac romac mentioned this issue Feb 6, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code Code/implementation related configuration Configuration of the node good first issue Good for newcomers
Projects
None yet
Milestone
Phase 5
Development

No branches or pull requests
1 participant
@romac