Add evidence command for monitoring and reporting misbehavior evidence to counterparty clients (#3456)

* evidence worker PoC for testing

* Cleanup

* Use ibc-proto branch with new provider message

* Add `MsgSubmitIcsConsumerMisbehaviour` domain type from `anca/ics-misbehaviour-handling` branch

* Report misbehavior evidence to all counterparty clients of the misbehaving chain

* Cleanup

* Submit CCV misbehaviour if needed

* Cleanup

* Check if counterparty is CCV provider

* Cleanup

* Add comment

* Set proposer address in header2

* Prepend client updates - work in progress

* Increase the timeout on CI (#3436)

* Improve some messages in `config auto` (#3438)

* Update Data-Requirements.md

Signed-off-by: Romain Ruetschi <[email protected]>

* Update Data-Requirements.md

Signed-off-by: Romain Ruetschi <[email protected]>

* Add CCV chain bootstrap to CI with Neutron and Gaia (#3451)

* Bump serde from 1.0.164 to 1.0.166 (#3458)

* Bump async-trait from 0.1.68 to 0.1.69 (#3459)

* Bump erased-serde from 0.3.25 to 0.3.26 (#3460)

* Document clock drift parameters in guide (#3420)

* Add clock-drift.md file to guide

* Add section on mis-configuring clock drift

* Update guide/src/advanced/troubleshooting/clock-drift.md

Co-authored-by: Anca Zamfir <[email protected]>
Signed-off-by: Sean Chen <[email protected]>

* Update guide/src/advanced/troubleshooting/clock-drift.md

Co-authored-by: Anca Zamfir <[email protected]>
Signed-off-by: Sean Chen <[email protected]>

* Remove redundant section

* Update guide/src/advanced/troubleshooting/clock-drift.md

Co-authored-by: Anca Zamfir <[email protected]>
Signed-off-by: Sean Chen <[email protected]>

* Update guide/src/advanced/troubleshooting/clock-drift.md

Co-authored-by: Anca Zamfir <[email protected]>
Signed-off-by: Sean Chen <[email protected]>

* Explain what `C` constant represents

* Add reference to forward lunatic attack

---------

Signed-off-by: Sean Chen <[email protected]>
Co-authored-by: Anca Zamfir <[email protected]>

* Bump uuid from 1.3.3 to 1.4.0 (#3461)

Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.3.3 to 1.4.0.
- [Release notes](https://github.com/uuid-rs/uuid/releases)
- [Commits](uuid-rs/uuid@1.3.3...1.4.0)

---
updated-dependencies:
- dependency-name: uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix wrong sequence number in `MsgTimeoutOnClose` (#3440)

The MsgTimeoutOnClose requires sequence of dstchannel.NextRecv in ordered channels, rather than packet.Sequence.
The code above resolve the sequence for ordered and unordered, just while creating msg it is ignored.

Signed-off-by: Puneet <[email protected]>

* Include client updates for supporting messages when assembling messages to relay from the operational data (#3468)

* Include client updates for supporting messages when assembling messages to relay from the operational data

* Add changelog entry

* Use `max_expected_time_per_block` value for the `max_block_time` (#3467)

* Use max_block_time queried from /genesis

* Clean solution

* Add unclog entry

* Remove serde-with dependency

* `config auto` now generates a config file even when it encounters an error (#3466)

* Stub out code flow

* Stub out code flow

* Change return type of `hermes_cofig` fn

* Define ConfigAutoError type

* Add some printlns

* Change `get_configs` return type

* Change AutoCmd::run

* Get it to compile

* Fix false reporting of missing chain configs

* Change get_data_from_handles

* Get it working

* Remove some debugging code

* Cargo fmt

* Update `get_configs` doc comment

* Update gas price warning in guide

* Cargo fmt

* Build client update for header at common height

* Add forking script

* Check for misbehavior in the last 100 blocks

* Add ICS misbehaviour test

* Add interchain-security to flake.nix

* Use cosmos.nix branch with proper version of interchain-security

* Remove test script

* Update guide templates

* Post-merge fixes

* Update deps

* Use latest ICS protos

* Adapt to change of `MsgSubmitIcsConsumerMisbehaviour::misbehaviour` to `Any` in upstream protos

* Submit both ICS and standard misbehaviour messages to provider chains

* Fix bug where update client message was dropped

* Revert changes of misbehaviour field to Any

* Submit consumer double voting evidence to the provider

* Formatting

* Fix clippy warnings

* Update guide templates

* fix: send evidences with non-empty infraction block header (#3578)

* try to fill infraction header in double voting msg

* reformat

* fix nit

* fmt

* Formatting

* Make infraction block header required

* Stop after submitting double voting evidence to the provider

* Force refresh of account before sending a tx

* Revert refresh on every call

* Remove hermes binary at root

* Send ICS misbehaviour for CCV consumer chain in misbehaviour worker

* Make the evidence command resilient to error, eg. because a client was already frozen

* Improve logging

* Go back to refreshing the account everytime

* Improve CI test script

* Improve logs

* Add `key-name` and `check-past-blocks` arguments to `evidence` command (#3603)

* Add `key-name` and `check-past-blocks` arguments to `evidence` command

* Update templates

* Better logs

* Update nix flake

* Patch check-guide tool with CCV protos

* Do not refresh account everytime

* Fix for zero height

* Update ICS misbehaviour test to use a different wallet for the `evidence` command

* Remove double sign script

---------

Co-authored-by: Romain Ruetschi <[email protected]>

* Fix post-merge conflict

* Better light client attack misbehaviour test

* Improve logs in fishy error cases

* Better error messages when client state is of unexpected type

* Gracefully handle unsupported client types

* WIP: Add double sign test

* Add test for consumer chain double signing

* Gracefully handle unsupported client types in `query connnections`

* Update flake lockfile

* Better logs in evidence command

* Rename jobs and script

* Fix evidence submission (#3612)

* Fix evidence submission by using fix in custom branch tendermint-rs

* Check that evidence command saw the evidence in the block

* Skip submitting evidence if client is already frozen or expired

* Skip frozen clients

* Add more delay in standard misbehaviour test

* Use latest tendermint-rs

* Properly compute the trusted validator set

* Cleanup

* Remove sleeps in double sign test

* Update ibc-proto

* Update ibc-proto to v0.36.0

* Do not panic when unable to find the chain

* Throttle the requests made to the chain while checking past blocks

* Add changelog entries

* Show logs on failure

* Update ibc-proto to v0.36.1

* Update `ibc-proto` to v0.38.0-pre.1 which includes the required CCV protos

* Improve logs

* Check for successful submission in the integration test

* Fix CI script for the case where the client is already frozen

* Submit the ICS misbehaviour for LCA and double signing even if client is
frozen.

* Fix clippy warning

* Avoid sending client updates without the misbehavior

* Include proposer in validator set

* Only submit ICS evidence when provider has a consensus state at the common height

* Update flake

* WIP: Use Rust light client to report evidence

* WIP: Use Go light client to detect misbehaviour

* Issue error when evidence is emitted at forked height

* Detect and report misbehaviour using the CometBFT light client to avoid freezing the client too early

* Add test for when the client is frozen already by the relayer

* Only send the ICS misbehaviour message when the provider client is already frozen

* Better cache frozen status of client

* Never send IBC message if client is already frozen

Co-authored-by: Anca Zamfir <[email protected]>
Signed-off-by: Romain Ruetschi <[email protected]>

* No need to submit client update if provider chain already has common consensus state

* Abort early if there are no messages to send

* Update comment

* Update double sign test

* Skip UpdateClient message if counterparty has consensus state at common height, whether or not it is a provider chain

* Improve logs a little bit

* Small refactor

* Check that counterparty client id matches the CCV client id on the provider

* Create a dummy connection to exercise the provider detection code

---------

Signed-off-by: Romain Ruetschi <[email protected]>
Signed-off-by: Sean Chen <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Puneet <[email protected]>
Signed-off-by: Romain Ruetschi <[email protected]>
Co-authored-by: Anca Zamfir <[email protected]>
Co-authored-by: Luca Joss <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sean Chen <[email protected]>
Co-authored-by: Anca Zamfir <[email protected]>
Co-authored-by: Puneet <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>

Author: 7 people

.changelog/unreleased/features/ibc-relayer-cli/3456-evidence-command.md

@@ -0,0 +1,4 @@
+- Add a new `evidence` command for monitoring the blocks emitted
+  by a chain for the presence of a misbehaviour evidence, and
+  report that evidence to all counteparty clients of that chain.
+  ([\#3456](https://github.com/informalsystems/hermes/pull/3456))

.changelog/unreleased/improvements/ibc-relayer/3219-ics-consumer-misbehavior.md

@@ -0,0 +1,4 @@
+- When Hermes detects a misbehaviour on a chain that is CCV
+  consumer, it will now send the misbehaviour evidence to the
+  provider chain using the new `IcsConsumerMisbehaviour` message.
+  ([\#3219](https://github.com/informalsystems/hermes/issues/3219))

.changelog/unreleased/improvements/ibc-relayer/3223-submit-misbehavior-all-clients.md

@@ -0,0 +1,5 @@
+- When Hermes detects a misbehaviour from a on-chain client, eg. a light
+  client attack or a double-sign, it will now submit the misbehaviour
+  evidence to all counterparty clients of the misbehaving chain
+  instead of to the counterparty client of the misbehaving client only.
+  ([\#3223](https://github.com/informalsystems/hermes/issues/3223))

.github/workflows/misbehaviour.yml

@@ -36,7 +36,7 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  misbehaviour:
+  light-client-attack:
     runs-on: ubuntu-20.04
     timeout-minutes: 20
     strategy:
@@ -91,3 +91,166 @@ jobs:
         run: |
           nix shell .#${{ matrix.chain.package }} -c bash misbehaviour_test.sh
 
+  ics-light-client-attack:
+    runs-on: ubuntu-20.04
+    timeout-minutes: 20
+    strategy:
+      fail-fast: false
+      matrix:
+        chain:
+          - package: interchain-security
+            account_prefix: cosmos
+    steps:
+      - uses: actions/checkout@v3
+      - name: Install Nix
+        uses: cachix/install-nix-action@v22
+        with:
+          extra_nix_config: |
+            experimental-features = nix-command flakes
+      - name: Use cachix cache
+        uses: cachix/cachix-action@v12
+        with:
+          name: cosmos
+      - name: Install sconfig
+        uses: jaxxstorm/[email protected]
+        with:
+          repo: freshautomations/sconfig
+          platform: linux
+          arch: amd64
+          extension-matching: disable
+          rename-to: sconfig
+          chmod: 0755
+      - name: Install stoml
+        uses: jaxxstorm/[email protected]
+        with:
+          repo: freshautomations/stoml
+          platform: linux
+          arch: amd64
+          extension-matching: disable
+          rename-to: stoml
+          chmod: 0755
+      - name: Install Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+      - name: Use Rust cache
+        uses: Swatinem/rust-cache@v1
+      - name: Build Hermes
+        uses: actions-rs/cargo@v1
+        with:
+          command: build
+      - name: Run test
+        working-directory: ci/misbehaviour-ics
+        run: |
+          nix shell .#cometbft .#${{ matrix.chain.package }} -c bash light_client_attack_test.sh
+
+  ics-light-client-attack-freeze:
+    runs-on: ubuntu-20.04
+    timeout-minutes: 20
+    strategy:
+      fail-fast: false
+      matrix:
+        chain:
+          - package: interchain-security
+            account_prefix: cosmos
+    steps:
+      - uses: actions/checkout@v3
+      - name: Install Nix
+        uses: cachix/install-nix-action@v22
+        with:
+          extra_nix_config: |
+            experimental-features = nix-command flakes
+      - name: Use cachix cache
+        uses: cachix/cachix-action@v12
+        with:
+          name: cosmos
+      - name: Install sconfig
+        uses: jaxxstorm/[email protected]
+        with:
+          repo: freshautomations/sconfig
+          platform: linux
+          arch: amd64
+          extension-matching: disable
+          rename-to: sconfig
+          chmod: 0755
+      - name: Install stoml
+        uses: jaxxstorm/[email protected]
+        with:
+          repo: freshautomations/stoml
+          platform: linux
+          arch: amd64
+          extension-matching: disable
+          rename-to: stoml
+          chmod: 0755
+      - name: Install Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+      - name: Use Rust cache
+        uses: Swatinem/rust-cache@v1
+      - name: Build Hermes
+        uses: actions-rs/cargo@v1
+        with:
+          command: build
+      - name: Run test
+        working-directory: ci/misbehaviour-ics
+        run: |
+          nix shell .#${{ matrix.chain.package }} -c bash light_client_attack_freeze_test.sh
+
+
+  ics-double-sign:
+    runs-on: ubuntu-20.04
+    timeout-minutes: 20
+    strategy:
+      fail-fast: false
+      matrix:
+        chain:
+          - package: interchain-security
+            account_prefix: cosmos
+    steps:
+      - uses: actions/checkout@v3
+      - name: Install Nix
+        uses: cachix/install-nix-action@v22
+        with:
+          extra_nix_config: |
+            experimental-features = nix-command flakes
+      - name: Use cachix cache
+        uses: cachix/cachix-action@v12
+        with:
+          name: cosmos
+      - name: Install sconfig
+        uses: jaxxstorm/[email protected]
+        with:
+          repo: freshautomations/sconfig
+          platform: linux
+          arch: amd64
+          extension-matching: disable
+          rename-to: sconfig
+          chmod: 0755
+      - name: Install stoml
+        uses: jaxxstorm/[email protected]
+        with:
+          repo: freshautomations/stoml
+          platform: linux
+          arch: amd64
+          extension-matching: disable
+          rename-to: stoml
+          chmod: 0755
+      - name: Install Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+      - name: Use Rust cache
+        uses: Swatinem/rust-cache@v1
+      - name: Build Hermes
+        uses: actions-rs/cargo@v1
+        with:
+          command: build
+      - name: Run test
+        working-directory: ci/misbehaviour-ics
+        run: |
+          nix shell .#${{ matrix.chain.package }} -c bash double_sign_test.sh
+