Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8896 - Added fix for switch click event #8898

Merged
merged 1 commit into from
Jul 19, 2024
Merged

8896 - Added fix for switch click event #8898

merged 1 commit into from
Jul 19, 2024

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Fixes the switch so you can click the label. Also updated the text to be more centered

Related github/jira issue (required):
Fixes #8896

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner July 12, 2024 15:42
@tmcconechy tmcconechy requested a review from jdilag90 July 12, 2024 15:42
@tmcconechy tmcconechy added type: patch ready for qa Ready for QA to review labels Jul 12, 2024
Copy link
Contributor

@jdilag90 jdilag90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now working as expected. However, it doesn't change the cursor upon hovering over the switch or label in Safari.

Screen.Recording.2024-07-15.at.12.35.32.PM.mov
Screen.Recording.2024-07-15.at.12.34.27.PM.mov
Screen.Recording.2024-07-15.at.12.36.17.PM.mov

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safari cursor works on my end.
Large GIF (842x474)
image

Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-capture.2.webm

@tmcconechy tmcconechy merged commit 8d8f4a4 into main Jul 19, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 8896-switch-click branch July 19, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready for QA to review type: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch: Click label doesn't change value.
5 participants