Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask: add option for process "number" to have minimum and maximum number value #8888

Open
aldsdelram opened this issue Jul 10, 2024 · 1 comment
Labels
team: m3 Issues for m3 and sub teams type: enhancement ✨ [5] Velocity rating (Fibonacci)

Comments

@aldsdelram
Copy link

Is your feature request related to a problem or use case? Please describe.
A clear and concise description of what the problem is. [e.g. {Component Name} has a problem when {...}]

  • We're using soho-mask for our input field for number.
    We have this use case where an input field will only accept a range of value.
    for example: ( min: -1,350,600,456, max: 1,540,000,000 ).
    as a work around, we've used for now the integerLimit option.
    in this example, we've used integerLimit of 10. but it will still accept 2,000,000,000.

image

Describe the solution you'd like
A clear and concise description of what you want to happen. [e.g. {Component Name} would work better if {...}]

  • add minValue and maxValue options to only accepts inside the range.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

  • We've tried using <input type=number> but it causes an issue with soho-mask, due to the separator symbols.

Additional context
Add any other context or screenshots about the feature request here.
And what application do you work on? M3 CLM

  • In addition, if in case this gets implemented, implementation of the minValue and maxValue to enterprise-ng is much appreciated.
@tmcconechy tmcconechy added type: enhancement ✨ [5] Velocity rating (Fibonacci) labels Jul 10, 2024
@tmcconechy
Copy link
Member

@aldsdelram this would be really hard since we are masking only typing not actual values (think of a regex on when you type). So i think this is out of scope for mask. I would use validation for that case.

@AAlviar AAlviar added the team: m3 Issues for m3 and sub teams label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: m3 Issues for m3 and sub teams type: enhancement ✨ [5] Velocity rating (Fibonacci)
Projects
Status: Groomed
Development

No branches or pull requests

3 participants