Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: Lookup cell does not get cell commit before a click handler #8840

Open
s-werking opened this issue Jun 20, 2024 · 2 comments
Open
Labels
team: lawson For lawson issues type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@s-werking
Copy link
Contributor

Describe the bug
When comparing a text input cell and a lookup cell, the cell commit timing happens differently when a button is clicked while the cell is still in edit mode.

For a text input cell, the cell commit happens and the dataset is updated before the button's click handler runs. For a lookup cell, the button's click handler runs before the cell commit occurs. This causes an issue if the button's handler is relying on the updated data on the lookup cell.

Could the lookup cell timing match what is done for the text input cells? I'm guessing this is also happening for datepicker and timepicker cells.

To Reproduce
Steps to reproduce the behavior:

  1. Go to this zipped html page: test-editable-lookup-save-btn.zip
  2. Click on a Price cell and type a new value
  3. Click the Save button
  4. Open the dev console to see that the dataset has been updated with the new cell value.
  5. Click on a Product Id cell and type a new value
  6. Click the Save button
  7. Open the dev console to see that the dataset has NOT been updated with the new cell value.

Expected behavior
It is expected that any active changes in the datagrid are considered committed upon clicking a button.

Version

  • ids-enterprise: 4.95.0-dev.0

Platform

  • Infor Application/Team Name: lawson
  • OS Version: Windows 11
  • Browser Name: chrome
  • Browser Version: 126.0.6478.63 (Official Build) (64-bit)
@tmcconechy tmcconechy added type: bug 🐛 [2] Velocity rating (Fibonacci) [3] Velocity rating (Fibonacci) and removed [2] Velocity rating (Fibonacci) labels Jun 24, 2024
@tmcconechy
Copy link
Member

@s-werking in the past folks have fixed this by calling commitCellEdit() in the button click. Maybe there is something we can do but not sure if its a good plan to put click events on every page button to do it. Maybe can think of some other events like page mouse down?

@s-werking
Copy link
Contributor Author

Hi @tmcconechy, yes we are handling it on our end for now with the commitCellEdit() call, but a permanent fix for those lookup, datepicker, and timepicker cells to match a regular text input cell would be nice to have. Thanks!

@AAlviar AAlviar added the team: lawson For lawson issues label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: lawson For lawson issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
Status: Check Back
Development

No branches or pull requests

3 participants