Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Text in message dialog is truncated #8839

Open
rvaja-infor opened this issue Jun 20, 2024 · 13 comments · May be fixed by #8944
Open

Modal: Text in message dialog is truncated #8839

rvaja-infor opened this issue Jun 20, 2024 · 13 comments · May be fixed by #8944
Assignees
Labels
team: sunsystems Issues for the Sunsystems (teams) type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@rvaja-infor
Copy link
Contributor

Describe the bug
The message dialog sometimes truncates the message text. In the attached screenshot you can observe that message text has been truncated. The text should read

The file does not exist in the system: 'file://C/Application/Administration/Data/ABC/ABC/ABC_PYMT_A_XYZAB_PARAMS.txt'

Steps to reproduce the behavior:

  1. Go to 'https://ids-enterprise-4930-amgax7.stackblitz.io'
  2. Click on 'Error Example' button
  3. Text in message dialog is truncated, see screenshot

Expected behavior
The message in the dialog should not be truncated and clearly visible.

Version

  • ids-enterprise: v4.93.0

Screenshots
image

Platform

  • Infor Application/Team Name: Infor SunSystems
  • Device: Windows Desktop
  • OS Version: Windows 11
  • Browser Name: Edge/Chrome
  • Browser Version: latest 64bt
@tmcconechy tmcconechy changed the title Text in message dialog is truncated Modal: Text in message dialog is truncated Jun 24, 2024
@tmcconechy tmcconechy added type: bug 🐛 [2] Velocity rating (Fibonacci) labels Jun 24, 2024
@tmcconechy
Copy link
Member

Maybe we can do something with css word-wrap here.

@rvaja-infor
Copy link
Contributor Author

Maybe we can do something with css word-wrap here.

I did look at this initially but it just don't look right. The only value that seem to have any effect was 'break-word', which produced the below.
image

Considering the string in single quotes is a path it does not feel right to word wrap it unless it looks meaningful. I did not propose to our analysts but can see what they think, but maybe rejected.

@tmcconechy
Copy link
Member

@rvaja-infor
Copy link
Contributor Author

Thought did cross my mind. Also a scrollbar for this. What I am trying to do here is effect other message dialogs and was looking for a more generic solution.

I may ask about the scrollbar as these paths can be any size which means I would need to find a sensible max-width, but that is not always going to be reasonable for some cases so the scrollbar may be the way forward.

@tmcconechy
Copy link
Member

I'll talk to our team as well for ideas

@rvaja-infor
Copy link
Contributor Author

@tmcconechy , had a closer look and see the issue.
The message div has a max-width of 369px. If this is removed then the message dialog expands to the content. Any reason for this max-width?

@tmcconechy
Copy link
Member

@rvaja-infor this max width was an attempt to get a reasonable sized message (what the designs originally showed). Maybe we can look at a way to unset max width.

@AAlviar AAlviar added the team: sunsystems Issues for the Sunsystems (teams) label Jul 16, 2024
@yohannahbautista
Copy link
Contributor

@rvaja-infor @tmcconechy
Hello, would setting maxWidth to 'fit-content' be a possible solution? https://stackblitz.com/edit/ids-enterprise-4930-vdasqa?file=index.html
It would avoid needing to specify a value for width.

@tmcconechy
Copy link
Member

Looks like a good solution to me... @yohannahbautista what do you think @rvaja-infor ?

@rvaja-infor
Copy link
Contributor Author

@tmcconechy , seems okay to me. Just so I have got the right end of the stick here, basically a new option is being added into the settings for message dialogs to specify max-width, is that correct?

@tmcconechy
Copy link
Member

@rvaja-infor that option already works i believe cc @yohannahbautista ?

@rvaja-infor
Copy link
Contributor Author

I just seen the option in the Enterprise controls we are currently on. Just not been exposed on our GWT wrapper, so not hard to sort out.

The documentation at https://design.infor.com/components/components/message/enterprise/, is not very clear how this setting can be used.

settings.maxWidth | string=null | Pass a specific string or defaults to null

We will however give this a try.

@tmcconechy
Copy link
Member

@yohannahbautista can you update the docs? Mention you can use fit-conent (or any valid css width)

@yohannahbautista yohannahbautista linked a pull request Aug 6, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: sunsystems Issues for the Sunsystems (teams) type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Status: Ready for Dev Pr Review
Development

Successfully merging a pull request may close this issue.

4 participants