Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable opening Google Images tab #634

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tdksk
Copy link

@tdksk tdksk commented Sep 27, 2024

This PR addresses the functionality to open Google Images tab and other tabs in the Google Images page, adapting to recent changes in Google's URL structure and page layout.

Related Issues

Changes

  1. Updated the selector for the Google Images tab to accommodate Google's URL structure change
  2. Updated selectors for other tabs in the Google Images page

Reason for Changes

Google Images Tab

Google recently changed the URL structure for Google Images, removing the tbm=isch parameter that was previously used to identify image search results. This change broke our existing functionality for opening the Google Images tab.

Technical Details

  • Previously, we used the selector 'a[href*="&tbm=isch"]' to identify the Google Images tab.
  • With Google's changes, the tbm parameter is no longer present in the URL.
  • We've identified that Google now uses udm=2 in the URL for image search results.
  • We've updated our selectors to use udm=2 instead of tbm=isch.

Other Tabs in Google Images Page

In addition to the URL structure change, Google also modified the selectors for other tabs in the Google Images page. This necessitated further updates to our codebase.

Technical Details

  • The selectors for other tabs in the Google Images page were no longer valid.
  • We've updated these selectors to match the new structure of the Google Images page.
  • This ensures that users can navigate to other tabs (e.g., Videos, News) while browsing image search results.

Implementation

  1. Modified our code to use the new udm=2 parameter to identify and interact with Google Images tabs.
  2. Updated selectors for other tabs in the Google Images page to match Google's new page structure.

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant