Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable collision in makefile.common and makefile.vars #109

Open
khous opened this issue Sep 13, 2021 · 0 comments · May be fixed by #111
Open

variable collision in makefile.common and makefile.vars #109

khous opened this issue Sep 13, 2021 · 0 comments · May be fixed by #111

Comments

@khous
Copy link
Contributor

khous commented Sep 13, 2021

DOCKER_RUNNER is defined in makefile.vars and makefile.common

This causes make targets like fmt and test to fail because the PWD is set to a directory which doesn't exist in the container

@khous khous linked a pull request Sep 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant